GitHub Actions Windows Coverage build on is broken #59369
Description
The Coverage Windows workflow on GitHub Actions is failing on main.
e.g. for 4f5d11e:
https://github.com/nodejs/node/actions/runs/16752649115/job/47426712106#step:6:6232
In file included from src\quic\data.cc:4:
src\quic\data.h(159,5): error : expected identifier [D:\a\node\node\libnode.vcxproj]
src\quic\data.h(111,5): message : expanded from macro 'QUIC_TRANSPORT_ERRORS' [D:\a\node\node\libnode.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\winerror.h(232,18): message : expanded from macro 'NO_ERROR' [D:\a\node\node\libnode.vcxproj]
src\quic\data.cc(152,46): error : invalid use of non-static data member 'base' [D:\a\node\node\libnode.vcxproj]
src\quic\data.cc(156,50): error : invalid use of non-static data member 'base' [D:\a\node\node\libnode.vcxproj]
src\quic\data.cc(160,51): error : invalid use of non-static data member 'base' [D:\a\node\node\libnode.vcxproj]
src\quic\data.cc(386,1): error : expected unqualified-id [D:\a\node\node\libnode.vcxproj]
src\quic\data.h(111,5): message : expanded from macro 'QUIC_TRANSPORT_ERRORS' [D:\a\node\node\libnode.vcxproj]AFAIK the Jenkins CI on Windows is passing, so I assume this is compiler level related?
cc @jasnell @nodejs/platform-windows
Activity
jasnell commentedon Aug 5, 2025
Ugh. Yeah, likely compiler related. I can revert that part of the change shortly. Will open a PR later today
quic: fixup NO_ERROR macro conflict on windows
quic: fixup windows coverage compile error
quic: fixup windows coverage compile error
quic: fixup NO_ERROR macro conflict on windows
quic: fixup windows coverage compile error
quic: fixup NO_ERROR macro conflict on windows
Merge upstream Node.js v24.18.1 into dotnet/main (#375)