You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
windows: install header files required for compiled addons #859
The windows installer should install header files. If we do this node-gyp wouldn't have to download a tarball to get the headers.
I would suggest to install them into program files\iojs\include.
I think this can be closed in favour of nodejs/node-gyp#1247, if we embed the headers in the binary then there's no need to have them separately in the installer.
I think this can be closed in favour of nodejs/node-gyp#1247, if we embed the headers in the binary then there's no need to have them separately in the installer.
OK, closing, but feel free to re-open etc. etc. etc.
I think this can be closed in favour of nodejs/node-gyp#1247, if we embed the headers in the binary then there's no need to have them separately in the installer.
OK, closing, but feel free to re-open etc. etc. etc.
but the "embed the headers in the binary" should be a node core issue...
Activity
sam-github commentedon Feb 16, 2015
+a bunch, needing proxy access to external internet in order to just compile a c++ addon is onerous.mscdex commentedon Feb 16, 2015
+1
cjihrig commentedon Feb 16, 2015
👍
piscisaureus commentedon Feb 17, 2015
I can do it myself, but this is also a reasonably simple patch that can be implemented by another contributor.
Trott commentedon Mar 28, 2016
Forgive me if this is a naïve question, but does this basically involve opening
tools/msvs/msiin Visual Studio and adding the header files there?Trott commentedon Jul 9, 2017
@piscisaureus @nodejs/build Should this remain open?
gibfahn commentedon Jul 9, 2017
I think this can be closed in favour of nodejs/node-gyp#1247, if we embed the headers in the binary then there's no need to have them separately in the installer.
Trott commentedon Jul 9, 2017
OK, closing, but feel free to re-open etc. etc. etc.
refack commentedon Jul 10, 2017
but the "embed the headers in the binary" should be a node core issue...
bnoordhuis commentedon Jul 10, 2017
I have it in my backlog.
refack commentedon Jul 10, 2017
Some of this conversation must have leaked into my subconscious, since two ideas came to me in a dream last night:
MMM.writeHeaderFiles(path)