Skip to content

fs: apply exclude function to root path - #57420

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
Trott:globbing-fix
Mar 16, 2025
Merged

nodejs-github-bot merged 4 commits into
nodejs:mainfrom
Trott:globbing-fix

Conversation

@Trott

@Trott Trott commented Mar 12, 2025

Copy link
Copy Markdown
Member

In at least some situations, the root path was
being added to the results of globbing even if
it matched the optional exclude function.

In the relevant test file, a variable was renamed
for consistency. (There was a patterns and pattern2, rather than patterns2.) The test case is added to
patterns2.

Fixes: #56260

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using glob can't exclude all directs

8 participants