Repository navigation
test: check build options when skipping config schema test - #66899
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
Check QUIC and DTLS build settings when skipping the schema test. Runtime feature helpers also depend on command-line flags. Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
inoway46
force-pushed
the
fix-config-schema-build-options
branch
from
October 21, 2026 13:30
02872f6 to
4c3a283
Compare
inoway46
marked this pull request as ready for review
October 21, 2026 13:35
marco-ippolito
approved these changes
Oct 21, 2026
aduh95
approved these changes
Oct 21, 2026
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Collaborator
richardlau
approved these changes
Oct 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66899 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 797 797
Lines 278502 278502
Branches 53540 53538 -2
=======================================
+ Hits 252247 252260 +13
+ Misses 16592 16580 -12
+ Partials 9663 9662 -1 🚀 New features to boost your workflow:
|
Collaborator
Contributor
|
Landed in ce9d650 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use build-time QUIC and DTLS settings when deciding whether to skip
test-config-json-schema. The runtime feature helpers also require command-line flags, so QUIC-enabled builds without--experimental-quicincorrectly compare their schema against the default-build schema.Refs: https://github.com/nodejs/node/actions/runs/39600664099/job/119224028865
Refs: https://github.com/nodejs/node/actions/runs/39594836686/job/119204469882