Skip to content

Revert doc redesign - #67015

Merged
aduh95 merged 6 commits into
nodejs:mainfrom
aduh95:revert-doc-redesign
Oct 26, 2026
Merged

aduh95 merged 6 commits into
nodejs:mainfrom
aduh95:revert-doc-redesign

Conversation

@aduh95

@aduh95 aduh95 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Refs: #66571

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Oct 26, 2026

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're actively working on having it running on all environments, we must revert the current status quo on main. SGTM.

@aduh95 aduh95 added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (d630b5d) to head (1ae4076).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67015      +/-   ##
==========================================
+ Coverage   90.59%   90.66%   +0.07%     
==========================================
  Files         797      797              
  Lines      278230   278262      +32     
  Branches    53482    53524      +42     
==========================================
+ Hits       252066   252298     +232     
+ Misses      16558    16375     -183     
+ Partials     9606     9589      -17     

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 26, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 26, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 26, 2026
This reverts commit 1bc3cda.

PR-URL: nodejs#67015
Refs: nodejs#66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
This reverts commit 2192f7f.

PR-URL: nodejs#67015
Refs: nodejs#66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
This reverts commit 28194a3.

PR-URL: nodejs#67015
Refs: nodejs#66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
This reverts commit df775ec.

PR-URL: nodejs#67015
Refs: nodejs#66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
This reverts commit 37d5c80.

PR-URL: nodejs#67015
Refs: nodejs#66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
This reverts commit 18a9ba5.

PR-URL: nodejs#67015
Refs: nodejs#66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95
aduh95 force-pushed the revert-doc-redesign branch from 4a6f168 to 1ae4076 Compare October 26, 2026 15:09
@aduh95
aduh95 merged commit 1ae4076 into nodejs:main Oct 26, 2026
18 of 19 checks passed
@aduh95

aduh95 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Landed in ba3c34a...1ae4076

@aduh95
aduh95 deleted the revert-doc-redesign branch October 26, 2026 15:10
ovflowd added a commit to avivkeller/node that referenced this pull request Oct 26, 2026
Reapplies the doc redesign and the follow-ups reverted in
nodejs#67015, so the rest of this pull
request applies on top of them:

- 18a9ba5 build, doc: move to redesign
- 37d5c80 build: toggle doc-kit verbosity based on V
- df775ec, 28194a3, 2192f7f tools: bump the doc group

The last doc group bump (1bc3cda) is left out, since the next
commit bumps the same packages to the same versions.

Refs: nodejs#66571
Assisted-by: a closed-source coding agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants