Switch lang-picker-toggler to a button #2545

Activity

1. moshfeu commented on Sep 10, 2019

   

   moshfeu

   on Sep 10, 2019

   More actions

   If you already touch it, it will be better to add more accessibility aspects to the list (options also should be focusable, aria-expanded, aria-haspopup etc.)
2. XhmikosR commented on Sep 10, 2019

   

   XhmikosR

   on Sep 10, 2019

   ContributorAuthor

   More actions

   See #2566

   Only toggling aria-expanded is left.
3. moshfeu commented on Sep 10, 2019

   

   moshfeu

   on Sep 10, 2019

   More actions

   🔥
   I'm not familiar with that syntax but I can't see how the options will be focusable (navigate via tabs, or even arrows)
4. XhmikosR commented on Sep 10, 2019

   

   XhmikosR

   on Sep 10, 2019

   ContributorAuthor

   More actions

   That doesn't work, unfortunately. Nor the toggler closes with the Esc key. But you are more than welcome to help me out in that PR :)
5. moshfeu commented on Sep 10, 2019

   

   moshfeu

   on Sep 10, 2019

   More actions

   Ok.
   I'll see what I can do :)
6. Trott

   closed this as completedin #2566on Sep 26, 2019