Repository navigation
feat: add support for Pushin (pushin.eu) as a git provider - #3317
Conversation
Shows stars, forks and watchers from Pushin's GitHub-compatible API, plus the provider icon and a "View on Pushin" link. Pushin doesn't serve raw files or have a releases API yet, so README relative images point at blob URLs and changelogs aren't supported. Closes npmx-dev#3303
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @Tobbe. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to Pushin support is mergeable after normal checks; its stated feature limits do not establish a merge-blocking issue. Pre-merge checks |
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
My name is Peter Ullrich and I approve this message 😬 Also: thanks for pointing out what's still missing. Releases will be released next week and I'll put the other things on my next-up todo list. 🫶 Edit: I'm the creator of Pushin.eu |
trueberryless
left a comment
There was a problem hiding this comment.
This is an amazing feature!
I am just blocking because @serhalp is currently working on integrating https://forges.link into npmx, so this feature will either be already supported when we have migrated or we can integrate it more easily later one.
trueberryless
left a comment
There was a problem hiding this comment.
After some discussion, we decided to merge this PR first to get Pushin support ASAP and we can iterate with forges later 👍
I took the liberty to push some smaller commits, so now everything looks good to me 🙌
Thank you very much, @Tobbe!
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
🔗 Linked issue
Closes #3303
🧭 Context
Adds Pushin (https://pushin.eu) as a supported git provider. I was at https://goatmire.com and noticed that a lot of talks/workshops/demos used pushin.eu for their code hosting. I got curious, and talked to the creator of Pushin, who was also at Goatmire.
I mentioned pushin on some Discord servers I'm part of, and @WilcoSp suggested it was added as a supported git provider to npmx. And of course I wanted to do that! A perfect reason to contribute to my favorite npm frontend 🙂
📚 Description
Packages with a pushin.eu repo now get stars, forks, watchers, the Pushin icon and a "View on Pushin" link.
Pushin doesn't support raw files, so I made
rawBaseUrlpoint at the blob URL. So relative images in READMEs won't work.Pushin currently has no support for releases (they list it as "coming soon"), so there's no changelog support
I also couldn't find a "forks" page, so the forks link just point to the repo itself
And for reference, here's that repo on pushin