Skip to content

ci: do not cancel target branch check to avoid failed checks on main - #3374

Merged
trueberryless merged 1 commit into
npmx-dev:mainfrom
trueberryless:ci/dont-cancel-target-branch-check
Oct 30, 2026
Merged

trueberryless merged 1 commit into
npmx-dev:mainfrom
trueberryless:ci/dont-cancel-target-branch-check

Conversation

@trueberryless

Copy link
Copy Markdown
Member

🧭 Context

Fix red CI on main.

📚 Description

This PR fixes the failing (canceled) enforce-release-source.yml check, which happens on main because multiple runs are triggered simultaneously there by removing the concurrency block entirely. This also means adding a zizmor ignore rule for this action only, but I think it is the best solution .

🔗 Related resources

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Oct 30, 2026 8:42pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Oct 30, 2026 8:42pm UTC
npmx-lunaria Ignored Ignored Oct 30, 2026 8:42pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 5477c91 and e633062.

Files selected for processing: 2
  • .github/workflows/enforce-release-source.yml
  • .github/zizmor.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated release-check automation settings. The check continues to run for pull requests with the same permissions and source validation.
    • Concurrency grouping is no longer configured for this check, and its concurrency-limit exception is documented.
    • These changes affect the project’s automation only; no changes to user-facing features or product behaviour are included.

The release-source workflow no longer sets concurrency options. The zizmor configuration now excludes this workflow from concurrency-limit checks and documents the stated concurrency behaviour.

Changes: Release-source workflow concurrency

Layer / File(s) Summary
Update release-source concurrency policy
.github/workflows/enforce-release-source.yml, .github/zizmor.yml
The workflow no longer defines a concurrency group or sets cancel-in-progress. The zizmor configuration excludes this workflow from concurrency-limits and documents the stated concurrency behaviour.

Suggested reviewers: alexdln, danielroe

Merge Risk: Minimal · up to e6330

The change removes concurrency restrictions from the release-source check without changing its validation logic. No actionable merge-blocking risk is identified; merge after normal checks pass.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names the main change: the workflow no longer cancels the target branch check. The raw summary confirms the concurrency block was removed from enforce-release-source.yml, which matches the t…
Description check Passed The description states the purpose: fixing the canceled enforce-release-source.yml check on main. It explains removing the concurrency block and adding a zizmor ignore rule. The related-resources link…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the workflow no longer cancels the target branch check. The raw summary confirms the concurrency block was removed from enforce-release-source.yml, which matches the title's intent. The title uses the 'ci:' prefix and stays under 70 characters. It does not describe the zizmor ignore rule, but that is a secondary change.

Full details: Description check

Explanation

The description states the purpose: fixing the canceled enforce-release-source.yml check on main. It explains removing the concurrency block and adding a zizmor ignore rule. The related-resources links cover earlier attempts, such as setting cancel-in-progress to false and restoring the synchronize trigger. All of this matches the changeset.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@trueberryless
trueberryless added this pull request to the merge queue Oct 30, 2026
Merged via the queue into npmx-dev:main with commit 67ca235 Oct 30, 2026
25 checks passed
@trueberryless
trueberryless deleted the ci/dont-cancel-target-branch-check branch October 30, 2026 21:00
trueberryless added a commit to BittuBarnwal7479/npmx.dev that referenced this pull request Oct 31, 2026

This branch was successfully deployed

1 active deployment
Preview – npmx.dev — e6330629 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants