Repository navigation
chore: unescape quotes in i18n/locales/en.json - #3393
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
i18n\locales\en.jsoni18n/locales/en.json
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update translation quote representation i18n/locales/en.json |
The no_stable_versions translation uses literal curly quotation marks instead of escaped characters. Its displayed wording is unchanged. |
Suggested reviewers: antfu
Merge Risk: 
Minimal · up to 79691
-
The translation displays identically. This localized representation change presents no identified merge-blocking risk, though it does not address the linked issue’s script behavior.
Pre-merge checks: 
3 · 
1
-
Failed checks: 1 warning Passed checks: 3 passed-
Full details: Title check
-
Explanation
The title names a real change in the changeset: unescaping quotes in i18n/locales/en.json. The raw summary confirms that the timeline message for disabling 'stable only' now uses literal curly quotation marks instead of Unicode escape sequences. The title uses the conventional commit prefix 'chore:', which fits a non-functional data-format change. It is short and specific. It does not cover the linked issue's request about script behaviour, but the check does not require full coverage, and the title matches the diff.
Full details: Description check
-
Explanation
The description contains only the unfilled template: HTML comment placeholders for context, description and checklist items, plus a linked issue reference (Closes
#3348). It does not describe the change. However, the linked issue is related to the changeset, and the description is not off-topic. Under the lenient criteria, the description is related to the changeset in some way because it links the issue that the PR addresses.
-
Full details: Linked Issues check
-
Explanation
Issue
#3348requires thei18n:report:fix/remove-unused-translationsscript to preserve\u201cand\u201descapes. The reviewed diff changes onlyi18n/locales/en.jsonand replaces those escapes with literal curly quotation marks. It does not implement or test the required script behaviour.Resolution
Update the script so its JSON output preserves the Unicode escapes, revert the unintended locale change, and add a regression test for
\u201cand\u201d.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
Closes #3348
🧭 Context
📚 Description