Skip to content

chore: unescape quotes in i18n/locales/en.json - #3393

Merged
trueberryless merged 1 commit into
mainfrom
roman/fix-3348
Nov 1, 2026
Merged

trueberryless merged 1 commit into
mainfrom
roman/fix-3348

Conversation

@gameroman

Copy link
Copy Markdown
Member

🔗 Linked issue

Closes #3348

🧭 Context

📚 Description

@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Nov 1, 2026 12:46am UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Nov 1, 2026 12:46am UTC
npmx-lunaria Ignored Ignored Nov 1, 2026 12:46am UTC

Request Review

@gameroman gameroman changed the title chore: unescape quotes in i18n\locales\en.json chore: unescape quotes in i18n/locales/en.json Nov 1, 2026
@gameroman
gameroman requested a review from a team November 1, 2026 00:44
@gameroman gameroman added the needs review This PR is waiting for a review from a maintainer label Nov 1, 2026
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between fefe4f6 and 79691cf.

Files selected for processing: 1
  • i18n/locales/en.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated the punctuation formatting in the timeline message. The displayed wording is unchanged.

The no_stable_versions translation in the English locale now uses literal curly quotation marks instead of Unicode escape sequences. The displayed wording is unchanged.

Changes: Translation format

Layer / File(s) Summary
Update translation quote representation
i18n/locales/en.json
The no_stable_versions translation uses literal curly quotation marks instead of escaped characters. Its displayed wording is unchanged.

Suggested reviewers: antfu

Merge Risk: Minimal · up to 79691

The translation displays identically. This localized representation change presents no identified merge-blocking risk, though it does not address the linked issue’s script behavior.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Linked Issues check Warning Issue #3348 requires the i18n:report:fix / remove-unused-translations script to preserve \\u201c and \\u201d escapes. The reviewed diff changes only i18n/locales/en.json and replaces those esc… Update the script so its JSON output preserves the Unicode escapes, revert the unintended locale change, and add a regression test for \\u201c and \\u201d.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title names a real change in the changeset: unescaping quotes in i18n/locales/en.json. The raw summary confirms that the timeline message for disabling 'stable only' now uses literal curly quotati…
Description check Passed The description contains only the unfilled template: HTML comment placeholders for context, description and checklist items, plus a linked issue reference (Closes #3348). It does not describe the chan…
Out of Scope Changes check Passed The change is limited to the affected timeline.no_stable_versions translation entry in i18n/locales/en.json. No unrelated files or changes appear in the reviewed diff.
Full details: Title check

Explanation

The title names a real change in the changeset: unescaping quotes in i18n/locales/en.json. The raw summary confirms that the timeline message for disabling 'stable only' now uses literal curly quotation marks instead of Unicode escape sequences. The title uses the conventional commit prefix 'chore:', which fits a non-functional data-format change. It is short and specific. It does not cover the linked issue's request about script behaviour, but the check does not require full coverage, and the title matches the diff.

Full details: Description check

Explanation

The description contains only the unfilled template: HTML comment placeholders for context, description and checklist items, plus a linked issue reference (Closes #3348). It does not describe the change. However, the linked issue is related to the changeset, and the description is not off-topic. Under the lenient criteria, the description is related to the changeset in some way because it links the issue that the PR addresses.

Full details: Linked Issues check

Explanation

Issue #3348 requires the i18n:report:fix / remove-unused-translations script to preserve \u201c and \u201d escapes. The reviewed diff changes only i18n/locales/en.json and replaces those escapes with literal curly quotation marks. It does not implement or test the required script behaviour.

Resolution

Update the script so its JSON output preserves the Unicode escapes, revert the unintended locale change, and add a regression test for \u201c and \u201d.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the tracking.ignoredKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@trueberryless
trueberryless added this pull request to the merge queue Nov 1, 2026
@trueberryless trueberryless added i18n Related to internationalization and removed needs review This PR is waiting for a review from a maintainer labels Nov 1, 2026
Merged via the queue into main with commit 3dd6987 Nov 1, 2026
36 of 38 checks passed
@trueberryless
trueberryless deleted the roman/fix-3348 branch November 1, 2026 07:49

This branch was successfully deployed

1 active deployment
Preview – npmx.dev — 79691cfc Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Related to internationalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooling: remove-unused-translations script converts escaped quotes

3 participants