Repository navigation
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-15 08:31 UTC Review the latest changes. Also blocked by: Merge conflicts. Status above doesn't look right?
|
Dotify71
force-pushed
the
fix-otlp-http-tls-validation
branch
from
November 13, 2026 07:47
b3c8dfc to
72fcb1c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5928
In PR #5781, TLS/mTLS support was introduced in declarative configuration. While
otlp_grpcvalidated certificate and key files at startup via_read_tls_file,otlp_httpexporters only verified thatkey_fileandcert_filewere set together without checking whether the referenced files actually existed or could be read.This meant missing certificates or typos in paths would not fail at configuration time, leading to silent failures or delayed errors when background worker threads attempted to export batches.
This change adds
_validate_http_tlsin_common.py, which:ca_file,cert_file, andkey_fileexist and can be read at startup, raisingConfigurationErrorto fail fast with a clear error message._create_otlp_http_span_exporter,_create_otlp_http_metric_exporter, and_create_otlp_http_log_exporter.Type of change
Checklist:
tox -e precommittest-opentelemetry-configuration,lint-opentelemetry-configuration)