Repository navigation
Conversation
Pull request dashboard statusWaiting on maintainers · refreshed 2026-11-15 07:18 UTC Merge when ready. Status above doesn't look right?
|
DylanRussell
approved these changes
Nov 13, 2026
5 of 9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #5886.
Tracer,Meter,Loggerand their providers now derive fromSignatureCompatABC, which wraps overrides that don't accept**kwargs. That wrapper adds a small per-call cost.This PR adds
**_kwargs: Neverto:**kwargs. This is intentional: it prompts implementors to add**_kwargs, which makes them forward compatible and avoids the wrapper.NoOp*,Proxy*) and the SDK, so none of them are wrapped anymore. This resolves theTODO(#5877)in_compat.py.Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck