Repository navigation
Conversation
Distros import opentelemetry.propagate and only then set OTEL_PROPAGATORS from configure(). The global text map was built at import, so that assignment had no effect. Read the variable on the first get_global_textmap() call. set_global_textmap() still takes precedence, and a failed load is not cached. Fixes open-telemetry#4679
eisen0419
force-pushed
the
fix/distro-override-otel-propagators
branch
from
November 14, 2026 08:09
5dce65e to
53c7761
Compare
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-14 08:10 UTC Review the latest changes. Status above doesn't look right?
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opentelemetry.propagatepreviously constructed the global text map fromOTEL_PROPAGATORSat import time. Because auto-instrumentation imports a distro before callingdistro.configure(), settingOTEL_PROPAGATORSinsideconfigure()happened after the defaulttracecontext,baggagecomposite was already cached (forcing workarounds such asimportlib.reload(propagate)).This defers loading
OTEL_PROPAGATORSuntil the firstget_global_textmap()call (including viaextract()orinject()):set_global_textmap()calls before or after first read still take precedence.importlib.reload(opentelemetry.propagate)continues to reset the cache._HTTP_TEXT_FORMATandOTEL_PROPAGATORSwithout reloading intearDownso test order does not leak global state (addressing the review question on opentelemetry-api: honor OTEL_PROPAGATORS set after import #5610).Fixes #4679