Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ dash/dcc/*
!dash/dcc/.gitkeep
dash/dash_table/*
!dash/dash_table/.gitkeep
dash/labextension/*
develop-eggs/
dist/
downloads/
Expand Down
4 changes: 4 additions & 0 deletions @plotly/dash-jupyterlab/install.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"packageName": "dash",
"packageManager": "python"
}
13 changes: 9 additions & 4 deletions @plotly/dash-jupyterlab/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@
},
"scripts": {
"build": "tsc",
"build:pack": "jlpm run prepare && jlpm pack --filename ../../dash/labextension/dist/dash-jupyterlab.tgz && jlpm run build:copy",
"build:copy": "cp package.json ../../dash/labextension/dist/package.json",
"build:pack": "jlpm run prepare && jupyter labextension build . && jlpm run build:copy",
"build:copy": "cp install.json ../../dash/labextension",
"clean": "rimraf lib",
"prepare": "mkdirp ../../dash/labextension/dist && jlpm run clean && jlpm run build",
"prepare": "mkdirp ../../dash/labextension && jlpm run clean && jlpm run build",
"prettier": "prettier --write '{!(package),src/**,!(lib)/**}{.js,.jsx,.ts,.tsx,.css,.json,.md}'",
"watch": "tsc -w"
},
Expand All @@ -38,13 +38,18 @@
"@jupyterlab/notebook": "^2.0.0 || ^3.0.0 || ^4.0.0"
},
"devDependencies": {
"@jupyterlab/builder": "^3.6.8",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI pins jupyterlab<4, so this bundle is built against Lab 3 core. Lab 4 is what most people run (#3828 is on 4.5.6), and src/index.ts imports @lumino/widgets, @lumino/messaging, @jupyterlab/services and @jupyterlab/coreutils without declaring them, so their shared versions come from Lab 3 core (@lumino/widgets ^1 vs 2.x in Lab 4). Which Lab versions did you test? Can you check that it loads on Lab 4 with no shared-module errors in the console, and declare those imports as dependencies with ranges that cover both majors?

"@types/json-schema": "^7.0.15",
"mkdirp": "^0.5.1",
"prettier": "2.0.5",
"rimraf": "3.0.2",
"typescript": "5.6.2"
},
"jupyterlab": {
"extension": true
"extension": true,
"outputDir": "../../dash/labextension"
},
"resolutions": {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the webpack pin fix? If it works around a builder 3 problem, please say so in the PR description so the next person knows when it can go.

"webpack": "5.106.2"
}
}
Loading