Repository navigation
fix(langneg): ignore whitespace-only language entries - #679
Open
poplolioi11 wants to merge 1 commit into
Open
poplolioi11 wants to merge 1 commit into
poplolioi11 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current main retains whitespace-only list elements as empty strings in
acceptedLanguages. For example,en-US, ,\t, frproduces["en-US", "", "", "fr"]; empty entries also get the default quality of 1 and can precede actual language tags.Trim the captured language once and skip it when empty before adding it to the sorting array. Preserve quality parsing, source indices and ordering of nonempty entries. This restores the previous empty-item behavior; published
@fluent/langneg@0.7.0is unaffected by this regression.Fixes #675. Ignoring reasonable empty list elements follows RFC 9110 section 5.6.1.2.
Validation on main
9a925d2:The evidence is limited to local synthetic language-list outputs. No downstream production failure or affected deployed service has been established.
AI assisted source/test preparation and a separate static review; the results above were verified by local execution.