Skip to content

Resync the .NET SDK-Line Rule and Skills Tree with the Hub - #264

Merged
ptr727 merged 2 commits into
developfrom
resync-sdk-line-skills
Nov 12, 2026
Merged

ptr727 merged 2 commits into
developfrom
resync-sdk-line-skills

Conversation

@ptr727

@ptr727 ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Summary

Resyncs PhotoCleaner with hub main at 009d3e5e, which promoted the hub's .NET SDK-line rule (ptr727/ProjectTemplate#4109).
The repository side of that rule already landed in #263, so this pull request carries only the rule text.

  • CODESTYLE.md: the .NET summary now names the root global.json that selects the SDK line, with LangVersion left unset so the C# version follows the TFM.
    The edit touches that one sentence, and the local adaptations (the OPERATIONS.md "Local Verification" link and "The Full Post-Change Set") are unchanged.
  • .github/skills: re-vendored with carry.py apply, after which the tree digest matches hub main.
    • dotnet-codestyle/SKILL.md, references/project-config.md, and references/testing.md carry the global.json and LangVersion rule.
    • merge-and-release/SKILL.md adds the Codex and opencode global-rules refresh to the release step.

Audit

Run stamp 2026-11-12T21:52:56Z, hub 009d3e5e, measured against develop.
The AGENTS.md and GOVERNANCE.md verbatim sections already match.
These intent findings were checked and need no change:

Verification

  • The repository meets the rule the skill now states.
    global.json pins 10.0.100 with rollForward: latestFeature and allowPrerelease: false, and no props or project file sets LangVersion.
  • The pre-commit hook built and formatted clean on SDK 10.0.404.
  • The hub prose gate and markdownlint pass on the changed files.
  • A local strict review over the whole diff recorded no findings.

🤖 Generated with Claude Code

ptr727 and others added 2 commits November 12, 2026 13:54
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 12, 2026 22:09
@ptr727

ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head c707ca18389ba08e8b0f5def73c61d259201a294, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The release procedure conditionally rewrites host-wide Codex and opencode rules, so its installer and reporting side effects require maintainer validation on a real hub host.

No open issues 🎉

What changed in this PR

Resynchronizes PhotoCleaner’s .NET SDK-line documentation and carried Skills with the hub. The changes document SDK selection through the root global.json, keep LangVersion derived from the target framework, and update release-host refresh guidance.

Changes:

  • Updates CODESTYLE.md with the SDK-line and TFM-derived C# version rules.
  • Refreshes the carried .NET Skills for SDK selection, testing, and project configuration.
  • Extends the release procedure with Codex and opencode global-rules refresh instructions.
File Description
CODESTYLE.md Adds the root global.json SDK selection and unset LangVersion policy to the .NET guidance.
.github/​skills/​merge-and-release/​SKILL.md Adds Codex and opencode global-rules refresh instructions to the release procedure.
.github/​skills/​dotnet-codestyle/​SKILL.md Documents the SDK-line, global.json, target framework, and C# language-version rules.
.github/​skills/​dotnet-codestyle/​references/​testing.md Documents the relationship between MTP test configuration and the shared SDK configuration.
.github/​skills/​dotnet-codestyle/​references/​project-config.md Adds guidance connecting the required SDK line with target framework and project configuration.

Review effort: Lite

@ptr727

ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

Declined, out of scope for this repository. The flagged text is .github/skills/merge-and-release/SKILL.md step 7, which opens "In the hub, when the chosen scope includes a release". So the Codex and opencode global-rules refresh never runs on a PhotoCleaner release. The file is also a byte-identical carry of hub main (sha256sum gives 0877592c... for both the PR copy and origin/main in ptr727/ProjectTemplate at 009d3e5e), and a verbatim carry cannot be edited here without becoming drift. Validating that step on a hub host belongs to the hub change that wrote it (ptr727/ProjectTemplate#4092 and #4096), not to this resync.

@ptr727

ptr727 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

Correction to the decline above: the hub change that wrote the merge-and-release step 7 refresh text is ptr727/ProjectTemplate#4094 (promoted in #4096), not #4092. git log origin/main -- .agents/skills/merge-and-release/SKILL.md in the hub names #4094 as the latest change. The rest of the decline stands.

@ptr727
ptr727 merged commit f61b8e4 into develop Nov 12, 2026
13 checks passed
@ptr727
ptr727 deleted the resync-sdk-line-skills branch November 12, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants