Repository navigation
State What the Fence Scanner Does in Its Comments - #4184
Conversation
Delete the comments that reasoned about a renderer's containers, and state the scan's own rules. A renderer is cited only where a test case pins the difference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Delete the docstring sentence that claimed a narrower class agrees with Python's split. A label before which Python-only whitespace sits is a counterexample. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The exemption's reason states both directions: a wider class can add a match and never splits one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
The guard reads named methods and the backslash-s spelling, not every whitespace comparison. The marker's reason goes back to the fact about the callers' labels, which cites no renderer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Two active nit findings remain in the release-guard tests: an unclear exception description and a docstring that overstates the guard’s whitespace-comparison coverage.
2 open issues
What changed in this PR
This pull request simplifies the fence scanner's comments and docstrings so they describe tested scanner behavior without changing executable logic.
Changes:
- Removes unsupported renderer, container, and historical-defect explanations.
- Retains documentation for behavior covered by tests.
- Narrows fence parsing and whitespace-guard commentary.
| File | Description |
|---|---|
| tests/test_release_guards.py | Removes unsupported scanner commentary and updates fence parsing, extraction, and whitespace-guard documentation without changing test logic. |
Review effort: Lite
|
A recorded local strict-review pass covers head |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4184 +/- ##
===========================================
- Coverage 81.60% 76.71% -4.89%
===========================================
Files 26 41 +15
Lines 9070 14317 +5247
===========================================
+ Hits 7402 10984 +3582
- Misses 1668 3333 +1665
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
/review |
Action not completed
|
… Rules (#4189) ## Summary Promotes the backlog-burndown rounds and changes from other hub sessions from `develop` to `main`. - Hooks and the prose gate: #4132, #4134, #4136, #4145, #4152, #4184. The Husky hook reads its path list once and diffs a merge against `MERGE_HEAD`. Interrupts re-raise their signal, a Markdown code span reads as quoted data, and the gate picks a commit's diff base and recognizes a conflicted promotion's branch cut from `main`. - Procedures and carried rules: #4133, #4139, #4141, #4149, #4166, #4177, #4179, #4183, #4185. Resync, audit and check-this-repo procedure gaps, code style and shell interrupt rules, review-loop gaps across four skills, the context and delegation section of `AGENTS.md`, question rules in governance, the promotion line in pull request bodies, closing-keyword behavior on promotion, and the history-rewrite premise. - Review and cleanup tooling: #4138, #4148, #4154, #4156, #4157, #4163, #4164, #4168, #4174, #4180. Cleanliness reads, parked handoffs, the backlog report's JSON output, exact inline script pins, trusted inputs, env-file includes, the bounded review wait, side-reviewer matching, and a Copilot billing-failure notice read as a refusal. - Workflow and runbook contract: #4153, #4155, #4169, #4171, #4178, #4182. The runtime-secrets check, a registry entry and spec references, the Copilot runbook pointers, credential-free checkout steps, and the deploy-key and runner wording. - From other hub sessions: #4159 (a repository's own .NET line under a fleet default), #4161 (the 1Password CLI as an optional host tool), #4162 (Codex's Windows installer and one managed opencode copy). These carry no promotion line. #4182 carries no promotion line by design, and #4175 holds the split-out part of #4057's scope. Both #1448 and #4175 stay open. Fixes #1071 Fixes #1154 Fixes #1391 Fixes #1471 Fixes #1594 Fixes #1620 Fixes #1627 Fixes #1650 Fixes #1801 Fixes #2853 Fixes #3620 Fixes #3668 Fixes #3697 Fixes #3766 Fixes #3787 Fixes #3837 Fixes #3840 Fixes #3842 Fixes #3844 Fixes #3865 Fixes #3882 Fixes #3890 Fixes #3894 Fixes #3912 Fixes #3916 Fixes #3954 Fixes #4014 Fixes #4015 Fixes #4016 Fixes #4043 Fixes #4050 Fixes #4057 Fixes #4058 Fixes #4062 Fixes #4084 Fixes #4097 Fixes #4098 Fixes #4099 Fixes #4104 Fixes #4108 Fixes #4114 Fixes #4115 Fixes #4117 Fixes #4118 Fixes #4119 Fixes #4121 Fixes #4122 Fixes #4123 Fixes #4131 Fixes #4135 Fixes #4140 Fixes #4142 Fixes #4143 Fixes #4144 Fixes #4151 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Summary
One pass over the fence scanner's comments and docstrings in
tests/test_release_guards.py, with deletion as the default. Each comment left states what the scan does. A renderer is cited only where a test case pins the difference. No test logic changed, and the suite passes.Disposition of the issue's items
Each item was re-verified against the current file first. The file now lives at
tests/test_release_guards.py, not underscripts/tests/.fenced_blocks. The body-indent comment keeps only its two lines that state the scan's rule.any-whitespace:marker stays on the line, and its inline reason now reads "no matched label holds whitespace", a fact about the callers' label sets rather than about a renderer.FENCE_LINE.Other deletions in the same pass
fenced_blocksdocstring's container and HTML-block reasoning. Its one load-bearing fact is restated as scan behaviour: a fence line met while a block is open either closes it or raises, so no labelled block is read as another's body.Local review findings from the opening push
The opening push spent its two-round
local-strict-reviewbudget with twointroducedfindings open. Each is now disposed of in ce88ccf, and the pass over that head recorded no findings.introduced, the.split()marker# any-whitespace: can add a match, never split one. Fixed. The marker now readsno matched label holds whitespace, a fact about the callers' label sets. An earlier pass asked the marker to also say that a wider split can add a match. That point is declined under the issue's own rule, since that says how another reader splits the label, and no case pins it.introduced, thefenced_blocksdocstring sentences claiming each whitespace comparison is named or marked and that a test holds that rule. Fixed by deletion. The guard reads named methods and the\sspelling only, so the claim was wider than the check.Closes on promotion: #1620
🤖 Generated with Claude Code