Add FontStyle enum #69

Activity

1. vyorkin commented on Jul 8, 2018

   

   vyorkin

   on Jul 8, 2018

   Collaborator

   More actions

   I've found there is already existing FontStyle newtype here: https://github.com/slamdata/purescript-css/blob/9e78699ea728f519ec5b3e830aa2036823dd50a7/src/CSS/Font.purs#L67 + values. Do you want to change this?
2. garyb commented on Jul 8, 2018

   

   garyb

   on Jul 8, 2018

   MemberAuthor

   More actions

   Perhaps this was missing when I opened the issue, but I think generally it might be nice to have "real types" rather than newtypes-over-strings for values that have a known set of possibilities?
3. vyorkin commented on Jul 8, 2018

   

   vyorkin

   on Jul 8, 2018

   Last edited by vyorkin

   Collaborator

   More actions

   Something like

   data ObliqueValue = ObliqueDefault | ObliqueAngle (Angle Value)
   data FontStyle = Normal | Italic | Oblique ObliqueValue

   ?
4. garyb commented on Jul 8, 2018

   

   garyb

   on Jul 8, 2018

   MemberAuthor

   More actions

   Yeah, exactly 👍

   👍React with 👍1Reacted by Vasiliy Yorkin
5. garyb

   closed this as completedin #95on Jul 8, 2018