Repository navigation
Add None, Inherit, Initial, and Unset instances for Transformation - #169
Merged
thomashoneyman merged 2 commits intoNov 9, 2026
Conversation
thomashoneyman
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Resolves #150.
Adds
None,Inherit,Initial, andUnsetinstances forTransformation, sotransform none,transform inherit,transform initial, andtransform unsetrender
transform: none,transform: inherit,transform: initial, andtransform: unset, all valid values of thetransformproperty per the MDNreference linked in the issue (
inherit,initialandunsetare CSS-widekeywords;
noneis specific to this property).The instance shape follows the repository's existing pattern for
BoxShadowinsrc/CSS/Box.purs, adapted with an explicitTransformation $ fromString "..."wrapper because
Transformationhas noIsStringinstance.TransformOriginintentionally receives no
Noneinstance, sincetransform-origindoes notaccept
none.A new
test/CSS/TransformSpec.pursasserts the exact rendered output for allfour keywords and is wired into
test/Main.purs, and a changelog entry is addedunder "Unreleased" -> "New features".
Checklist:
TransformlacksNone,Inherit,Initial, andUnsetinstances #150 and @jibranshaikh0; the PR link will be added once the PR number exists)TransformlacksNone,Inherit,Initial, andUnsetinstances #150TransformSpecasserts the exact rendered CSS for all four keywordsTesting (exact scope)
Verified by automated validation in a clean checkout with the repository's own CI
commands (Node 22, purescript 0.15.16, spago 1.0.5, purs-tidy):
spago build --strict— passes with no warnings or errorsspago test— passes; the new spec confirmstransform: none,transform: inherit,transform: initial, andtransform: unsetrenderexactly
purs-tidy check src test— passesVerification is at the compiler and test-suite level only, matching how this
library is consumed (a compile-time DSL). No downstream application was built
with the patched library, and no manual testing beyond the automated suite
above was performed.
AI assistance disclosure: the implementation, tests, and this PR description
were prepared with AI assistance.