Repository navigation
fix(stl): reject non-iterable classes named like builtin iterables - #6243
Open
kroplabeskidu wants to merge 2 commits into
Open
kroplabeskidu wants to merge 2 commits into
kroplabeskidu wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Item 13 from #6159. The STL casters accept some builtin iterables by matching
tp_name(map,zip,dict_keys,dict_values,dict_items). A user class with one of those names passes the check even if it isn't iterable. Release builds then raiseTypeError: 'map' object is not iterablefrom inside the caster, which stops overload resolution. The review reports that debug builds hit theisinstance<iterable>assert and abort; I only ran this test on a release build before the fix.A name match now also requires the object to be iterable, so the caster returns false and the next overload gets a chance.
The review suggests rejecting heap types. I used an iterability check because it doesn't rely on how PyPy and GraalPy flag these types. As a result, an iterable user class named
mapis still accepted, same as before.Suggested changelog entry: