Skip to content

Bedevere should label "awaiting merge" after a core review #584

Closed

Description

@hugovk

Steps to reproduce

  1. PR has "awaiting review" label
  2. A core dev approves it

Actual result

Bedevere removes "awaiting review" and adds "awaiting core review"

(This is what should happen when a non-core dev approves.)

Expected result

Bedevere removes "awaiting review" and adds "awaiting merge"

For example:

image

And:

image

See also

State diagram at https://github.com/python/bedevere#pr-state-machine

Activity

  1. self-assigned this
    on Sep 23, 2023
  2. Mariatta commented on Sep 23, 2023

    @Mariatta
    Member

    I'll take a look tomorrow.

  3. pradyunsg commented on Oct 13, 2023

    @pradyunsg
    Member

    @Mariatta and I investigated this yesterday, and this has been resolved.

    For posterity: The bot was recently migrated from a GitHub (bot) account to a GitHub App. During this migration, insufficient permissions were provided to the bedevere GitHub App -- it did not have the permission to query the membership to teams within the python organisation. This meant that the bot could not determine who is a core team member, and would label PRs as if everyone reviewing PRs is not a core developer.

    Adding the relevant permission resolved this issue.

  4. hugovk commented on Oct 13, 2023

    @hugovk
    MemberAuthor

    Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions