You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
socket.getservbyname(), socket.getservbyport(), socket.getprotobyname() are not threadsafe #74667
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee=Noneclosed_at=Nonecreated_at=<Date2017-05-26.09:32:15.697>labels= ['extension-modules', 'type-bug', '3.7']
title='socket.getservbyname(), socket.getservbyport(), socket.getprotobyname() are not threadsafe'updated_at=<Date2017-05-27.07:09:19.668>user='https://github.com/dwfreed'
On at least Linux (and probably most other UNIXes, except OS X), the C functions getservbyname(), getservbyport(), and getprotobyname() are not threadsafe. CPython's wrappers around these functions in the socket module do nothing to cover up this fact. Simple reproduction script for getservbyname (others similar):
import threading
import socket
def getservbyname_loop(service, port):
while True:
result = socket.getservbyname(service)
if result != port:
raise RuntimeError("thread-safety broken, got %d, expected %d" % (result, port))
thread1 = threading.Thread(target=getservbyname_loop, args=("ssh", 22))
thread2 = threading.Thread(target=getservbyname_loop, args=("smtp", 25))
thread1.start()
thread2.start()
One of the threads will throw the RuntimeError, saying it got the port number the other thread should have gotten.
Naive fix: a lock (eg, just use the netdb_lock already created in the module)
Proper fix: use the libc's reentrant variant if available, and fall back to locking if not (see gethostbyname_ex() implementation for example).
I'd be happy to work on this, but as I don't have access to anything other than Linux and OS X at the moment, it would be helpful if platform maintainers could chime in on what if any reentrant variants of these functions exist on their platforms so we can have a more proper fix.
The configure.ac script should check for the availability of gethostbyname_r and friends, like it already does for other functions.
dwfreed commented on May 26, 2017
dwfreedmannequin
MannequinAuthor
More actions
It already checks for gethostbyname_r, but the comments in socketmodule.c mention that configure seems to get it wrong. Those comments are probably old, though, so perhaps that can be revisited as well.
Activity
dwfreed commentedon May 26, 2017
On at least Linux (and probably most other UNIXes, except OS X), the C functions getservbyname(), getservbyport(), and getprotobyname() are not threadsafe. CPython's wrappers around these functions in the socket module do nothing to cover up this fact. Simple reproduction script for getservbyname (others similar):
One of the threads will throw the RuntimeError, saying it got the port number the other thread should have gotten.
Naive fix: a lock (eg, just use the netdb_lock already created in the module)
Proper fix: use the libc's reentrant variant if available, and fall back to locking if not (see gethostbyname_ex() implementation for example).
I'd be happy to work on this, but as I don't have access to anything other than Linux and OS X at the moment, it would be helpful if platform maintainers could chime in on what if any reentrant variants of these functions exist on their platforms so we can have a more proper fix.
pitrou commentedon May 26, 2017
The configure.ac script should check for the availability of gethostbyname_r and friends, like it already does for other functions.
dwfreed commentedon May 26, 2017
It already checks for gethostbyname_r, but the comments in socketmodule.c mention that configure seems to get it wrong. Those comments are probably old, though, so perhaps that can be revisited as well.
pythongh-74667: Make socket.getservbyname(), getservbyport() and getp…
pythongh-74667: Address review: larger netdb buffer, clearer probe co…