Repository navigation
Closed
Labels
docsDocumentation in the Doc dirDocumentation in the Doc dirtestsTests in the Lib/test dirTests in the Lib/test dirtopic-tkintertype-featureA feature request or enhancementA feature request or enhancement
Description
| BPO | 38649 |
|---|---|
| Nosy | @serhiy-storchaka, @lambertdw |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/serhiy-storchaka'
closed_at = None
created_at = <Date 2019-10-30.19:37:05.672>
labels = ['type-feature', 'tests', '3.10', 'docs']
title = 'tkinter messagebox is sloppy'
updated_at = <Date 2020-12-25.21:56:35.834>
user = 'https://github.com/lambertdw'bugs.python.org fields:
activity = <Date 2020-12-25.21:56:35.834>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = False
closed_date = None
closer = None
components = ['Documentation', 'Tests']
creation = <Date 2019-10-30.19:37:05.672>
creator = 'David Lambert'
dependencies = []
files = []
hgrepos = []
issue_num = 38649
keywords = []
message_count = 4.0
messages = ['355729', '355762', '360092', '383769']
nosy_count = 3.0
nosy_names = ['docs@python', 'serhiy.storchaka', 'David Lambert']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38649'
versions = ['Python 3.10']Linked PRs
- gh-82830: Improve tkinter messagebox docstrings and cursor documentation #152380
- [3.15] gh-82830: Improve tkinter messagebox docstrings and cursor documentation (GH-152380) #152386
- [3.14] gh-82830: Improve tkinter messagebox docstrings and cursor documentation (GH-152380) #152387
- [3.13] gh-82830: Improve tkinter messagebox docstrings and cursor documentation (GH-152380) #152388
Metadata
Metadata
Assignees
Labels
docsDocumentation in the Doc dirDocumentation in the Doc dirtestsTests in the Lib/test dirTests in the Lib/test dirtopic-tkintertype-featureA feature request or enhancementA feature request or enhancement
Projects
- StatusShow more project fieldsTodo
Activity
lambertdw commentedon Oct 30, 2019
Does aksokcancel return "true" or True ? The docstring should say True This is pervasive throughout the module. tkinter has such a mishmash of numbers supplied as strings, strings supplied as constants making this carelessness egregious. On the topic of constants, the messagebox module redefines OK. You might argue that the definition didn't change. I suspect this issue applies to all versions of tkinter or Tkinter having the messagebox.
# replies
...
OK = "ok"
brettcannon commentedon Oct 31, 2019
Please note that calling something "sloppy" and that somehow its development was done in some "carelessness" fashion to the point of being "egregious" is not motivating to others to try and help. Trying to support all of this code for free in one's spare time is not easy, so I would ask you try to be more understanding and nicer in your comments.
lambertdw commentedon Jan 16, 2020
Sometimes I say nice things about python.
https://www.quora.com/Is-Python-fast-yet/answer/David-Lambert-86?__nsrc__=4&__snid3__=6376944631
On 10/31/19 1:14 PM, Brett Cannon wrote:
serhiy-storchaka commentedon Dec 25, 2020
I agree that there is a problem. tkinter.messagebox is poorly documented. Different functions can return True, False, None or the name of the button, and it is not specified which function what returns. Set of acceptable values for type and icon are not documented. And there are no tests, so we cannot be sure that all works as expected on all platforms.
I am working on it.
serhiy-storchaka commentedon Jun 27, 2026
PR #152380 corrects the
messagebox.ask*docstrings to say they returnTrue(not "true"), notes thataskquestionreturns the symbolic button name, and fixesaskretrycancelto say "retry". (TheOK"redefinition" is intentional — the option type and the reply share the value"ok".)gh-82830: Improve tkinter messagebox docstrings and cursor documentat…
[3.13] gh-82830: Improve tkinter messagebox docstrings and cursor doc…
[3.14] gh-82830: Improve tkinter messagebox docstrings and cursor doc…
[3.15] gh-82830: Improve tkinter messagebox docstrings and cursor doc…