Repository navigation
gh-132983: Remove EndlessZstdDecompressor remains - #133856
Merged
AA-Turner merged 4 commits intoMay 11, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @emmatyping @AA-Turner (can't request review)
In
pyzstdthere was anEndlessZstdDecompressorclass implemented in the C module. Some remains of the code were left, this PR aims to remove them.In the comments,
<D>refers toZstdDecompressorwhereas<E>refers toEndlessZstdDecompressor. I cleaned that up as well.There was
_unused_char_for_alignin theZstdDecompressorstruct. My understanding is that it was placed only for optimization indecompressor_reset_sessionwhen setting several attributes to 0 at once. I removed it here, but if needed I can re-add it (twice to compensate the removal ofat_frame_edge).