Skip to content

gh-132983: Remove EndlessZstdDecompressor remains - #133856

Merged
AA-Turner merged 4 commits into
python:mainfrom
Rogdham:remove-endlessdzstddecompressor-remains
May 11, 2025
Merged

AA-Turner merged 4 commits into
python:mainfrom
Rogdham:remove-endlessdzstddecompressor-remains

Conversation

@Rogdham

@Rogdham Rogdham commented May 10, 2025 •

Copy link
Copy Markdown
Contributor

cc @emmatyping @AA-Turner (can't request review)

In pyzstd there was an EndlessZstdDecompressor class implemented in the C module. Some remains of the code were left, this PR aims to remove them.

In the comments, <D> refers to ZstdDecompressor whereas <E> refers to EndlessZstdDecompressor. I cleaned that up as well.

There was _unused_char_for_align in the ZstdDecompressor struct. My understanding is that it was placed only for optimization in decompressor_reset_session when setting several attributes to 0 at once. I removed it here, but if needed I can re-add it (twice to compensate the removal of at_frame_edge).

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants