Repository navigation
Fix stubtest issues - #5360
Fix stubtest issues#5360
Conversation
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| grp.struct_group._asdict | ||
| grp.struct_group._make | ||
| grp.struct_group._replace | ||
| mmap.MADV_SOFT_OFFLINE # Not defined in some linuxes |
There was a problem hiding this comment.
Is this needed for CI or for running stubtest on your computer? I think .github/workflows/stubtest-unused-whitelist.yml will delete this automatically if the CI doesn't need it.
There was a problem hiding this comment.
Also, MADV_SOFT_OFFLINE is new on Linux 2.6.33 (see madvise(2) manual page), so unless something hasn't been updated for the past 15 years, this shouldn't be a problem.
|
Failed on CI.
See
https://github.com/hatal175/typeshed/runs/2520806762?check_suite_focus=true
…On Fri, May 7, 2021, 14:16 Akuli ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/stubtest_whitelists/linux.txt
<#5360 (comment)>:
> @@ -10,6 +10,7 @@ grp.getgrgid
grp.struct_group._asdict
grp.struct_group._make
grp.struct_group._replace
+mmap.MADV_SOFT_OFFLINE # Not defined in some linuxes
Is this needed for CI or for running stubtest on your computer? I think
.github/workflows/stubtest-unused-whitelist.yml will delete this
automatically if the CI doesn't need it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5360 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYQXXMUWMPS5TSF3PEIUUDTMPDXTANCNFSM44I62DZQ>
.
|
|
This turned out to be a bug in glibc. I compiled my own Python 3.9 and edited @@ -1623,6 +1624,8 @@ PyInit_mmap(void)
#endif
#ifdef MADV_SOFT_OFFLINE
setint(dict, "MADV_SOFT_OFFLINE", MADV_SOFT_OFFLINE);
+#else
+ #error its missing lol
#endif
#ifdef MADV_HUGEPAGE
setint(dict, "MADV_HUGEPAGE", MADV_HUGEPAGE);Then it didn't compile anymore. The problem is that it's not in any of the includes that Nobody has reported this bug yet. I was going to report this by clicking "File a bug" here, but they they want an email address and they have a warning about receiving spam to it. I think we should delete |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| collections.abc.ItemsView.__reversed__ | ||
| collections.abc.KeysView.__reversed__ | ||
| collections.abc.ValuesView.__reversed__ | ||
| concurrent.futures.ProcessPoolExecutor.map |
There was a problem hiding this comment.
I wonder why this wasn't deleted last Saturday when stubtest-unused-whitelist.yml ran
No description provided.