[retyui]

Summary:

Previously, the Metro inline plugin for Platform didn't work inside React Native files that used ES imports for Platform (making require() the only way for the inline plugin to do its job).

Read more: react/metro#1521 (comment)

Since the inline plugin was moved from metro to react-native-babel-preset (PR: #57848), this issue has been resolved, so using require() is no longer necessary.

Changelog:

[INTERNAL] [CHANGED] - Use ES module imports for Platform API

Test Plan:

...

[vzaidman]

@robhogan was there a reason to require it and not import it?

[retyui]

@vzaidman also for reference PR that did opposite : #57121

[robhogan]

@robhogan was there a reason to require it and not import it?

Yes, previously the Metro inline plugin wouldn't detect imports of Platform unless experimentalImportSupport was enabled to replace Babel ESM->CJS. So Meta's pipeline would inline imports of Platflorm but OSS by default only inlined require.

The new RN inline plugin can handle import because it works on source before ESM lowering, so this change should be safe.

It's be great to see an end-to-end release JS bundle before and after to prove that this doesn't change what's inlined.

[meta-codesync]

@vzaidman has imported this pull request. If you are a Meta employee, you can view this in D120122290.

[meta-codesync]

@vzaidman merged this pull request in b9adf95.