Repository navigation
Conversation
|
Hi @paulnewby! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Fixes #59406.
On iOS 16+ with the New Architecture, ending dictation in a controlled single-line
TextInputinserts the dictated text twice.RCTTextInputComponentView's_textOf:equals:only falls back to a plain-text comparison during dictation whentextInputMode.primaryLanguageis"dictation", which iOS 16+ no longer reports. The attributed-string comparison then fails, the echoedvalueis written back into the field mid-dictation, and iOS inserts its final result again.The old architecture fixed this in #37188 (for #36045) by also checking
dictationRecognizing. This PR adds the same check to Fabric.dictationRecognizingis already onRCTBackedTextInputViewProtocol.Changelog:
[IOS] [FIXED] - Fix dictated text being duplicated in controlled single-line TextInput on the New Architecture
Test Plan:
Reproducer: https://github.com/paulnewby/rn-dictation-reproducer (RN 0.88.0, controlled single-line
TextInput, physical device required). iPad (10th generation), iPadOS 26, 5 attempts each, dictation ended with the keyboard mic key:Tested on 0.88.0 built from source (
RCT_USE_PREBUILT_RNCORE=0); this hunk applies unchanged tomain.Before:
rn088-dictation-stock.mp4
After:
rn088-dictation-patched.mp4