Repository navigation
Conversation
Time.parse and Time.strptime silently ignored offsets such as "GMT+0300" or "UTC-05:30" and returned a local time instead, because Time.zone_offset only recognized bare numeric offsets. This is the format produced by JavaScript's Date#toString, e.g. "Sat Oct 10 2026 10:47:00 GMT+0300 (Eastern European Summer Time)", so the parsed instant was off by the difference between the given offset and the local one. Date._parse and DateTime.parse already handle these offsets. Allow an optional GMT or UTC prefix before the numeric offset forms that zone_offset already supports.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Time.parseandstrptimewith%Zignore offsets likeGMT+0300andUTC-05:30(the JavaScriptDate#toStringformat) and silently fall back to local time, whileDateTime.parsealready handles them.Detail
I added an optional
GMT/UTCprefix on the numeric offset forms thatTime.zone_offsetalready accepts. Single-digit forms such asGMT+3stay unsupported because of POSIX sign ambiguity. This does not touch timezone abbreviations, unlike rejected Bug #12190.Test
Added coverage for
GMT±HHMM,UTC±HH:MM, and related prefixed numeric offsets throughTime.zone_offset/Time.parse.