Repository navigation
fix: ignore development version suffixes when checking for updates - #726
Merged
Merged
Conversation
Development builds use "git describe" versions such as v4.11.0-9-g154975a, and feature builds are tagged as v4.11.0-example-feature. Both are cut on top of the v4.11.0 release, but semver orders them before it, so the update check suggested "upgrading" to the release they're built from. The prerelease suffix of the current version is now ignored when comparing, since our versioning doesn't increment the version before attaching rc or feature tags. Newer stable releases are still suggested. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 78.12% 78.12% -0.01%
==========================================
Files 238 238
Lines 18114 18115 +1
==========================================
Hits 14152 14152
- Misses 3962 3963 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zimeg
marked this pull request as ready for review
October 27, 2026 22:53
mwbrooks
enabled auto-merge (squash)
October 28, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Development and feature builds of the Slack CLI are no longer prompted to "upgrade" to the release they were built from.
Summary
This pull request ignores the prerelease suffix of the current version when checking for updates, so development builds aren't suggested a downgrade.
git describeversions likev4.11.0-9-g154975a, and feature builds are tagged likev4.11.0-example-feature. Both come after thev4.11.0release, but semver orders prereleases before it, so the update check suggestedv4.11.0-9-g154975a → 4.11.0.v4.11.0holds for suggesting the next stable version. A newer release likev4.12.0is still suggested.Preview
Before
After
Testing
make buildand confirm./bin/slack --versionshows avX.Y.Z-N-g<hash>version./bin/slack upgradeand confirm "You are using the latest Slack CLI version"SLACK_TEST_VERSION=v4.11.0-example-feature ./bin/slack upgradeand confirm the same messageSLACK_TEST_VERSION=v4.10.0 ./bin/slack upgradeand confirm a newer version is still suggestedNotes
vX.Y.Z-rc.NbeforevX.Y.Zin the future, this comparison would need to treat those as earlier than the release.Requirements
🤖 Generated with Claude Code