Repository navigation
fix(math): preserve safe integer arithmetic and bound GCD work - #2243
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2238.
Safe integer inputs can currently produce fractional LCM results and incorrect Pascal coefficients because intermediate products exceed JavaScript's exact integer range. The iterative GCD also performs an impractical number of subtractions for widely separated inputs.
Divide by the GCD before multiplying for LCM, retain exact BigInt intermediate coefficients for Pascal rows, and use remainder steps in the iterative Euclidean algorithm. Pascal rows still return numbers; results outside the safe integer range retain Number's precision limitations.
Validation: all 178 test suites / 593 tests pass with coverage, and ESLint passes. New precision regressions fail before the changes. An independent BigInt oracle also matched 40,402 GCD cases; the original implementation times out on the large unbalanced regression.
AI assistance was used to investigate, implement, and validate this change.