Repository navigation
fix(shell-sort): stop insertion at an ordered gap pair - #2244
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2234.
Shell sort currently walks the entire gap subsequence even after a comparison needs no swap. Stop that insertion pass at the first ordered pair, since the earlier portion of the gap subsequence is already sorted.
For 4,000 sorted values, this reduces comparisons from 12,831,965 to 40,006. Add a regression bounding visits by n * ceil(log2(n)), and update the existing exact visit counts to reflect the reduced work. Sorting results and input preservation remain covered by the existing tests.
Validation: the new regression fails on the original implementation. The complete test suite with coverage and ESLint pass.
AI assistance was used to investigate, implement, and validate this change.