Repository navigation
fix(fenwick-tree): reject noninteger positions before traversal - #2246
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fenwick tree operations check the position's range but not whether it is an integer.
increase(1.5, 7)writes fractional array properties,query(NaN)silently returns zero, andquery(1.5)never terminates: its loop reaches 0.5, whose bitwise low bit is zero.Require integer positions in the existing update/query range guards, preserving the existing error message. Range queries inherit the same validation. Add regressions for fractional updates and queries and NaN bounds; the potentially nonterminating query runs with a bounded VM timeout so a regression cannot hang the test runner.
Validation: all 178 suites / 591 tests pass with coverage, and ESLint passes. The original fractional query times out, while the fix rejects it. Independent plain-array comparisons verify 189,000 prefix/range sums after positive and negative updates.
AI assistance was used to investigate, implement, and validate this change.