Repository navigation
fix(cache): skip .git in directory listings - #903
Open
jasonkuhrt wants to merge 2 commits into
Open
jasonkuhrt wants to merge 2 commits into
jasonkuhrt wants to merge 2 commits into
Conversation
A task that lists a directory records each entry's name and kind. `.git`
is a directory in an ordinary checkout and a file in a `git worktree`, so
a task that lists the workspace root never replayed between the two,
though every file it could read was the same:
○ cache miss: '.git' added in workspace root
Reads under `.git` are already left out of the fingerprint. Leave the
entry out of listings too, as `.DS_Store` and `dist` are.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #902
Motivation
A task that lists a directory records each entry's name and kind.
.gitis a directory in an ordinary checkout and a file in agit worktree, so a task that lists the workspace root never replays between the two, though every file it can read is the same. The miss reads○ cache miss: '.git' added in workspace root. In #902, a fresh worktree at our trunk's head missed 56vp lintentries that CI, checking out with a.gitdirectory, had recorded for that commit.Change
should_ignore_entrynow skips.git, as it skips.DS_Storeanddist. Reads under.gitare already left out of the fingerprint bytracked_accesses.rs, so this brings listings in line with reads. Like the other names, it applies to listings at any depth, which also covers a git submodule, whose.gitis a file too.The new e2e case
git_worktree_listingruns a task that lists the workspace root with.gitas a directory, replaces it with a worktree's.gitfile, and runs the task again. Onmainthe second run misses with'.git' added in workspace root; with this change it replays.