Repository navigation
feat(cache): let a hit rebuild folders that hold only the task's outputs - #914
Merged
Merged
Conversation
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
from
October 30, 2026 03:19
91b15b8 to
b25c11e
Compare
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
from
October 30, 2026 04:07
b25c11e to
4dff101
Compare
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
2 times, most recently
from
October 30, 2026 07:08
9f74d41 to
9ad3c84
Compare
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
from
November 5, 2026 08:54
9ad3c84 to
b1e69c1
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Cases for a task that reads a folder holding only its own outputs. In `stat_own_output_folder`, the task makes `out`, writes `out/a.txt` and stats `out`, through `vtt fs`. In `typescript_out_dir`, TypeScript 7's `tsc` compiles `src` into `dist`: it stats `dist` and lists the package root, where the hard-coded `dist` skip hides the folder. Two more cases clean up their output folder before writing a new one, and record their cache entry on a built tree: an input changes, so the task reruns over its existing output. In `clean_and_rebuild_output_folder`, the task lists `out`, removes it and writes it again, through `vtt fs` and its new `rm` operation. In `tsdown_rebuild_after_edit`, tsdown (added to `packages/tools`) lists `dist`, removes what it holds and bundles `src/index.ts` into it again. Today removing the output folder, as on a clean checkout, is a cache miss naming the folder, although the cached outputs hold everything in it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A task that stats or lists a folder holding only its own outputs, like TypeScript 7's `tsc` statting `dist`, pinned that folder as an input, so removing it, as on a clean checkout, was a cache miss although the task writes every file in it. A task that cleans up its output folder before writing a new one, like tsdown listing `dist` and removing what it holds, pinned it the same way once it ran over an existing output, as the `clean_and_rebuild_output_folder` and `tsdown_rebuild_after_edit` cases show. After the run, `Rebuildable` now climbs from the written paths through their parent folders inside the workspace and lists each folder in the real file system, deepest first. A folder is rebuildable when it isn't empty, every file or symlink in it is a path the task wrote, and every folder in it is rebuildable; climbing stops at the first folder that isn't. A folder that is gone by then, like the `dist/.prerender` that Astro writes to and deletes, plays no part, like a written file that is gone: its parent is decided by the entries it holds. A rebuildable folder the task read gets no inferred-input fingerprint. Only those fingerprints ask about folders, so a task with no inferred reads, like one with automatic input tracking off, skips the climb. The archive is unchanged: a hit restores the files in such a folder if they're among the task's outputs, which recreates it; explicit output config can leave them out. An empty folder isn't rebuildable yet, and a listing of the folder's parent still names it. `vt_path` gets `RelativePath::parent` for the climb. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
feat/cache-rebuildable-folders
branch
from
November 5, 2026 09:02
b1e69c1 to
3bd9097
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A task that stats or lists a folder holding only its own outputs pins that folder as an input. TypeScript 7's
tsc, for example, statsdistwhile emitting into it. Removing the folder, as on every clean checkout in CI, is then a miss, although the task writes every file in it. A task that cleans its output folder before writing a new one, like tsdown listingdistand removing what it holds, pins it the same way once it runs over an existing output.Changes
After the run, vt climbs from the written paths through their parent folders and lists each folder once, deepest first. A folder is rebuildable when it isn't empty, every file or symlink in it was written by the task, and every folder in it is rebuildable. A folder that's gone by then, like Astro's
dist/.prerender, plays no part. A rebuildable folder the task read gets no inferred-input fingerprint. Only those fingerprints ask about folders, so a task with no inferred reads skips the climb. A hit restores the folder's files if they're among the task's outputs, which recreates it; explicit output config can leave them out.vt_pathgetsRelativePath::parent.E2E cases:
stat_own_output_folder(synthetic) andtypescript_out_dir(TypeScript 7 emitting todist): removing the output folder misses today and hits with the folder restored after.clean_and_rebuild_output_folder(synthetic) andtsdown_rebuild_after_edit(tsdown): a task that cleans its output folder and writes a new one misses today after the folder is removed, and hits after.Part of a stack that lets automatic tracking cache tasks which read their own outputs and list the folders holding them, so they also hit on a clean checkout.
🤖 Generated with Claude Code
Note
Medium Risk
Changes core task-cache fingerprinting for directory reads; incorrect rebuildable detection could cause stale cache hits or miss legitimate invalidations.
Overview
Tasks that stat or list an output directory (e.g.
tscondist, or a bundler that wipesdistbefore writing) no longer miss the cache when that folder is gone on a clean checkout. After a run, vt walks parent directories of everything the task wrote and treats a directory as rebuildable when every entry is task output (nested rebuildable dirs included); those paths are omitted from post-run input fingerprints, so a later run can still hit and replay archived outputs to recreate the tree.Implementation centers on an expanded
Rebuildable(with_folders,is_rebuildable_folder), wiring inobserve_fspy/PostRunFingerprint::create, plusRelativePath::parentfor the climb. Docs and changelog describe the behavior;vtt fs rmsupports synthetic e2e scenarios, with new snapshot fixtures (andtsdown/tsccases, some markedignore).Reviewed by Cursor Bugbot for commit 3bd9097. Bugbot is set up for automated code reviews on this repo. Configure here.