Skip to content

ci(fuzz): fix self-cancelling concurrency in fuzzer autofix - #8203

Merged
joseph-isaacs merged 1 commit into
developfrom
ji/fix-fuzzer-autofix-concurrency
Jun 2, 2026
Merged

joseph-isaacs merged 1 commit into
developfrom
ji/fix-fuzzer-autofix-concurrency

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Jun 1, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Filing/labeling a fuzzer issue triggers fuzzer-issue-autofix.yml, which calls the reusable fuzzer-fix-automation.yml. Both used the same concurrency group name, fuzzer-fix-<issue>:

  • caller fuzzer-issue-autofix.yml: group: fuzzer-fix-${{ github.event.issue.number }}
  • callee fuzzer-fix-automation.yml: group: fuzzer-fix-${{ inputs.issue_number || github.run_id }}

A reusable workflow runs inside its caller's run. When the caller's autofix job invoked the reusable workflow, the callee entered the identical group with cancel-in-progress: true and cancelled its own parent run.

@codspeed

codspeed Bot commented Jun 1, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1273 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation chunked_varbinview_canonical_into[(1000, 10)] 162.1 µs 198 µs -18.12%
⚡ Simulation chunked_varbinview_canonical_into[(100, 100)] 309.2 µs 273.2 µs +13.16%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ji/fix-fuzzer-autofix-concurrency (2a4d715) with develop (326b475)

Open in CodSpeed

fuzzer-issue-autofix.yml (the issues-triggered caller) uses concurrency
group `fuzzer-fix-<issue>` to collapse the duplicate opened+labeled events
GitHub emits. The reusable fuzzer-fix-automation.yml used the *same* group
name. Because a reusable workflow runs inside its caller's run, entering the
identical group with cancel-in-progress made the fixer cancel its own parent:
the run failed after the gate job with no fix job ever starting, and no fix
PR was produced for issues filed via the label trigger.

Namespace the reusable workflow's group as `fuzzer-fix-automation-<issue>`
so it no longer collides with the caller. Direct workflow_dispatch
invocations are still deduped per issue.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs
joseph-isaacs force-pushed the ji/fix-fuzzer-autofix-concurrency branch from d1c8662 to 2a4d715 Compare June 1, 2026 18:02
@joseph-isaacs
joseph-isaacs enabled auto-merge (squash) June 2, 2026 11:39
@joseph-isaacs
joseph-isaacs merged commit ff5c197 into develop Jun 2, 2026
75 of 79 checks passed
@joseph-isaacs
joseph-isaacs deleted the ji/fix-fuzzer-autofix-concurrency branch June 2, 2026 11:39
mwlon pushed a commit to mwlon/vortex that referenced this pull request Jun 2, 2026
This PR contains the following updates:

| Package | Change |
[Age](https://docs.renovatebot.com/merge-confidence/) |
[Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@tanstack/react-virtual](https://tanstack.com/virtual)
([source](https://github.com/proxy/redirect.github.com/TanStack/virtual/tree/HEAD/packages/react-virtual))
| [`3.13.25` →
`3.13.26`](https://renovatebot.com/diffs/npm/@tanstack%2freact-virtual/3.13.25/3.13.26)
|
![age](https://developer.mend.io/api/mc/badges/age/npm/@tanstack%2freact-virtual/3.13.26?slim=true)
|
![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@tanstack%2freact-virtual/3.13.25/3.13.26?slim=true)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the [Dependency
Dashboard](..vortex-data/issues/357) for more information.

---

### Release Notes

<details>
<summary>TanStack/virtual (@&vortex-data#8203;tanstack/react-virtual)</summary>

###
[`v3.13.26`](https://github.com/proxy/redirect.github.com/TanStack/virtual/blob/HEAD/packages/react-virtual/CHANGELOG.md#31326)

[Compare
Source](https://github.com/proxy/redirect.github.com/TanStack/virtual/compare/@tanstack/react-virtual@3.13.25...@tanstack/react-virtual@3.13.26)

##### Patch Changes

- Updated dependencies
\[[`fc992ab`](https://github.com/proxy/redirect.github.com/TanStack/virtual/commit/fc992ab00a15166311b79bd7580736cf01e8cc1a)]:
-
[@&vortex-data#8203;tanstack/virtual-core](https://github.com/proxy/redirect.github.com/tanstack/virtual-core)@&#8203;3.16.0

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - Between 12:00 AM and 03:59 AM, only on Monday (`* 0-3 * * 1`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/vortex-data/vortex).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMDIuMSIsInVwZGF0ZWRJblZlciI6IjQzLjIwMi4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJjaGFuZ2Vsb2cvY2hvcmUiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants