[knagaitsev]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Adds clientMode: 'ws' with tests to confirm that it works, including full e2e tests.

Breaking Changes

None

Additional Info

[codecov]

Codecov Report

Merging #2090 into master will increase coverage by 0.28%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
+ Coverage   94.46%   94.74%   +0.28%     
==========================================
  Files          32       32              
  Lines        1210     1256      +46     
  Branches      334      360      +26     
==========================================
+ Hits         1143     1190      +47     
+ Misses         65       64       -1     
  Partials        2        2

Impacted Files	Coverage Δ
lib/utils/getSocketClientPath.js	88.88% <100%> (+1.38%)	⬆️
client-src/default/utils/createSocketUrl.js	100% <0%> (ø)	⬆️
lib/Server.js	97.29% <0%> (+0.36%)	⬆️
lib/utils/getSocketServerImplementation.js	93.1% <0%> (+3.62%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a09420...c671a08. Read the comment docs.

[alexander-akait]

/cc @hiroppy

[alexander-akait]

/cc @Loonride something wrong with node@6 😕

[knagaitsev]

/cc @Loonride something wrong with node@6

I think this was just a very unsuccessful e2e test run, not particular to node 6. Unless there is something in the output that I missed