Skip to content

Embed the comment editor #1197

Closed
Closed

Description

@Martii

As @sizzlemctwizzle mentioned a while back embed the comment editor similar to GH.

This should be done before #601 and #735 e.g. as they are dependent upon this.

Pros:

  • Older browsers, such as the Sony PS3, some "smart" phone apps, etc. (people do use internet appliances rather than a real machine), don't currently support the popup method. Just like here on GH with the popdown to logout... quite a nuisance for testing.
  • Can allow reuse for Consider Ability to Edit Comments/Discussions #601 just like GH e.g. you can edit multiple posts including new ones all at the same time.
  • On portable devices, even new ones, the popup blocks most of the page content especially when an on screen keyboard takes over a large portion of the viewport. Scrolling with touch on a very small area is not pleasant. Desktops usually don't have this issue. This is the most important reason.

Cons:

Activity

  1. added
    UIPertains inclusively to the User Interface.
    on Oct 23, 2017
  2. added this to the #601 milestone on Oct 23, 2017
  3. self-assigned this
    on Oct 26, 2017
  4. added a commit that references this issue on Oct 27, 2017
    2ecdf9f
  5. added a commit that references this issue on Oct 27, 2017
    7433c5e
  6. removed their assignment
    on Oct 27, 2017
  7. locked as resolved and limited conversation to collaborators on Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    UIPertains inclusively to the User Interface.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions