Repository navigation
Embed the comment editor - #1204
Merged
Merged
Conversation
* Few minor HTML fixes * Rewrote client side script to not be in jQuery. Polyfill for older browsers.. applies to OpenUserJS#904 * Reference FAQ and GFM Closes OpenUserJS#1197
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Oct 30, 2017
* Change some icons around * Add a tooltip * Move default licensing arbitration to view instead of code... allows visual detection Post OpenUserJS#1204 OpenUserJS#191 Loosely related to OpenUserJS#116, and OpenUserJS#944 via OpenUserJS#970
Martii
added a commit
that referenced
this pull request
Oct 30, 2017
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
May 30, 2019
* Allows some browser back button to work in certain browsers due to logoff condition. Edge use case. NOTE: * This is a **work-around** for those browsers not implementing back-browser action in a consistent non-destructive manner. Currently present in Chromium back-ends but not Mozilla based or Safari based. Nice inconsistency google! Perhaps this is a bug to add to their collection. Probable refetch instead of cache pull *(and listen)* in those affected browsers which can be another imposed DoS vector. * No known current way, w/o additional DoS vector added, to address for newTopic logoff condition e.g. out of luck atm. Post OpenUserJS#1204 Refs: * https://openuserjs.org/scripts/AltoRetrato/IMDb_My_Movies_enhancer/issues/does_it_still_work!#comment-16af97e508e *(subtle report not yet done on development)* * https://stackoverflow.com/questions/39920118/chrome-forces-page-refresh-on-window-history-back *(unanswered and long time issue)* * OpenUserJS#1548 (comment) *(about:flags note ... perhaps there is another one to disable bad browser acting)*
Martii
added a commit
that referenced
this pull request
May 30, 2019
* Allows some browser back button to work in certain browsers due to logoff condition. Edge use case. NOTE: * This is a **work-around** for those browsers not implementing back-browser action in a consistent non-destructive manner. Currently present in Chromium back-ends but not Mozilla based or Safari based. Nice inconsistency google! Perhaps this is a bug to add to their collection. Probable refetch instead of cache pull *(and listen)* in those affected browsers which can be another imposed DoS vector. * No known current way, w/o additional DoS vector added, to address for newTopic logoff condition e.g. out of luck atm. Post #1204 Refs: * https://openuserjs.org/scripts/AltoRetrato/IMDb_My_Movies_enhancer/issues/does_it_still_work!#comment-16af97e508e *(subtle report not yet done on development)* * https://stackoverflow.com/questions/39920118/chrome-forces-page-refresh-on-window-history-back *(unanswered and long time issue)* * #1548 (comment) *(about:flags note ... perhaps there is another one to disable bad browser acting)* Auto-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1197