You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(query-devtools/tsdown.config): add '@refresh skip' banner so the app's 'solid-refresh' does not wrap the bundled Solid runtime - #12517
Adds /* @refresh skip */ as a postBanner to every @tanstack/query-devtools build output.
@tanstack/query-devtools bundles its own Solid runtime (alwaysBundle: [/./]). When the package resolves outside node_modules (workspace links, pnpm link), vite-plugin-solid treats the prebuilt files as app source and solid-refresh wraps their components with the app's solid-js. The two runtimes then mix, and opening a page with the devtools in a SolidStart dev server throws Cannot read properties of undefined (reading 'sources').
@refresh skip is the directive solid-refresh provides to opt a file out. Installs from npm resolve inside node_modules, which the plugin already skips, so they are unaffected. Runtime code is unchanged; only the leading comment is added, and the sourcemaps account for the extra line.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.
🚀 Release Impact
This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).
Summary by CodeRabbit
Bug Fixes
Improved compatibility for Query Devtools in apps using Solid’s refresh tooling, helping the devtools runtime behave more reliably during development. This change applies to both development and production builds.
No actionable comments were generated in the recent review.
Walkthrough
The query devtools build configuration adds a /* @refresh skip */ post-build banner to production and development outputs. A patch changeset records the update.
TanStack/query#12423: Adds Solid applications that use @tanstack/solid-query-devtools, which depends on @tanstack/query-devtools.
TanStack/query#12483: Adds Solid applications that use @tanstack/solid-query-devtools, including a refresh-enabled entry point.
TanStack/query#12507: Adds a SolidStart integration that imports @tanstack/solid-query-devtools.
Suggested reviewers:tkdodo
Merge Risk: Minimal · up to 4129e
The change opts generated devtools files out of Solid refresh without changing runtime logic. No actionable merge-blocking risk is identified.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly identifies the affected package, configuration file, and purpose of the change. It is specific and directly matches the main changeset and build configuration updates.
Description check
The description follows the required template. It explains the change and motivation, completes the checklist, and records the changeset for the published-code change.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between d5781a4 and 4129ea1.
Files selected for processing: 2
.changeset/query-devtools-refresh-skip.md
packages/query-devtools/tsdown.config.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Adds
/* @refresh skip */as apostBannerto every@tanstack/query-devtoolsbuild output.@tanstack/query-devtoolsbundles its own Solid runtime (alwaysBundle: [/./]). When the package resolves outsidenode_modules(workspace links,pnpm link),vite-plugin-solidtreats the prebuilt files as app source andsolid-refreshwraps their components with the app'ssolid-js. The two runtimes then mix, and opening a page with the devtools in a SolidStart dev server throwsCannot read properties of undefined (reading 'sources').@refresh skipis the directivesolid-refreshprovides to opt a file out. Installs from npm resolve insidenode_modules, which the plugin already skips, so they are unaffected. Runtime code is unchanged; only the leading comment is added, and the sourcemaps account for the extra line.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit