Skip to content

docs(examples/solid): render 'SolidQueryDevtools' in 'pagination' SolidStart 2 example - #12527

Merged
sukvvon merged 1 commit into
mainfrom
chore/examples-solid-pagination-solid-start2-devtools
Nov 5, 2026
Merged

sukvvon merged 1 commit into
mainfrom
chore/examples-solid-pagination-solid-start2-devtools

Conversation

@sukvvon

@sukvvon sukvvon commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

Render SolidQueryDevtools in the pagination-solid-start2 example, matching the other SolidStart 2 examples.

  • Add @tanstack/solid-query-devtools to the example's dependencies.
  • Render <SolidQueryDevtools /> inside QueryClientProvider in src/app.tsx.
  • Update pnpm-lock.yaml for the new workspace dependency.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • New Features
    • Added a query devtools panel to the Solid pagination example.

@sukvvon sukvvon self-assigned this Nov 5, 2026
@changeset-bot

changeset-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a2c686f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit a2c686f

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 9m 4s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-11-05 01:42:21 UTC

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

1 package(s) bumped directly, 23 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/solid-query-devtools 5.106.0 → 5.106.1 Changeset
@tanstack/angular-query-experimental 5.106.0 → 5.106.1 Dependent
@tanstack/eslint-plugin-query 5.106.0 → 5.106.1 Dependent
@tanstack/lit-query 0.2.35 → 0.2.36 Dependent
@tanstack/preact-query 5.106.0 → 5.106.1 Dependent
@tanstack/preact-query-devtools 5.106.0 → 5.106.1 Dependent
@tanstack/preact-query-persist-client 5.106.0 → 5.106.1 Dependent
@tanstack/query-async-storage-persister 5.106.0 → 5.106.1 Dependent
@tanstack/query-broadcast-client-experimental 5.106.0 → 5.106.1 Dependent
@tanstack/query-core 5.106.0 → 5.106.1 Dependent
@tanstack/query-devtools 5.106.0 → 5.106.1 Dependent
@tanstack/query-persist-client-core 5.106.0 → 5.106.1 Dependent
@tanstack/query-sync-storage-persister 5.106.0 → 5.106.1 Dependent
@tanstack/react-query 5.106.0 → 5.106.1 Dependent
@tanstack/react-query-devtools 5.106.0 → 5.106.1 Dependent
@tanstack/react-query-next-experimental 5.106.0 → 5.106.1 Dependent
@tanstack/react-query-persist-client 5.106.0 → 5.106.1 Dependent
@tanstack/solid-query 5.106.0 → 5.106.1 Dependent
@tanstack/solid-query-persist-client 5.106.0 → 5.106.1 Dependent
@tanstack/svelte-query 6.3.10 → 6.3.11 Dependent
@tanstack/svelte-query-devtools 6.3.10 → 6.3.11 Dependent
@tanstack/svelte-query-persist-client 6.3.10 → 6.3.11 Dependent
@tanstack/vue-query 5.106.0 → 5.106.1 Dependent
@tanstack/vue-query-devtools 6.3.10 → 6.3.11 Dependent

@sukvvon sukvvon changed the title chore(examples/solid): render 'SolidQueryDevtools' in 'pagination' SolidStart 2 example docs(examples/solid): render 'SolidQueryDevtools' in 'pagination' SolidStart 2 example Nov 5, 2026
@pkg-pr-new

pkg-pr-new Bot commented Nov 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12527

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12527

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12527

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12527

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12527

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12527

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12527

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12527

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12527

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12527

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12527

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12527

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12527

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12527

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12527

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12527

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12527

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12527

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12527

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12527

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12527

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12527

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12527

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12527

commit: a2c686f

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The SolidStart pagination example adds @tanstack/solid-query-devtools and renders SolidQueryDevtools inside QueryClientProvider, before the router.

Changes: Solid Query Devtools Integration

Layer / File(s) Summary
Add and render devtools
examples/solid/pagination-solid-start2/package.json, examples/solid/pagination-solid-start2/src/app.tsx
The example adds @tanstack/solid-query-devtools version ^5.106.0, imports SolidQueryDevtools, and renders it inside QueryClientProvider before the router.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Possibly related PRs

  • TanStack/query#12524: Changes the server-rendered output of SolidQueryDevtools, which the SolidStart example renders.
  • TanStack/query#12517: Addresses a Solid dev server issue involving workspace-resolved devtools packages, which this example adds.
Merge Risk: Minimal · up to a2c68

The example gains query devtools without an identified merge-blocking issue. Mergeable subject to normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: rendering SolidQueryDevtools in the pagination SolidStart 2 example.
Description check Passed The description includes the required Changes, Checklist, and Release Impact sections. It explains the dependency and code changes, records testing and policy checks, and identifies the change as docs…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Changes, Checklist, and Release Impact sections. It explains the dependency and code changes, records testing and policy checks, and identifies the change as docs/dev-only.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f078a2b and a2c686f.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 2

  • examples/solid/pagination-solid-start2/package.json
  • examples/solid/pagination-solid-start2/src/app.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.84 KB (0%)
react minimal 8.66 KB (0%)

@sukvvon
sukvvon merged commit b165677 into main Nov 5, 2026
9 checks passed
@sukvvon
sukvvon deleted the chore/examples-solid-pagination-solid-start2-devtools branch November 5, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant