Skip to content

test(audit): 51 weak tests fixed, 23 fewer tests, since 19a11eb - #1039

Open
V3RON wants to merge 2 commits into
mainfrom
chore/audit-tests-2026-10-28
Open

V3RON wants to merge 2 commits into
mainfrom
chore/audit-tests-2026-10-28

Conversation

@V3RON

@V3RON V3RON commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Range: 19a11eb..6316e10 (since the last test(audit): commit #849). Tests only.

Read (15 of 168 changed files, most changed lines first): src/cli/index, src/daemon/main, src/daemon/server, src/updater/index, src/ports/service-manager, ui/src/state/queries, src/agent-device/edge, src/http/app, src/drivers/ios/index, src/gateway/dispatcher, src/leasing/create-leasing, src/spec-lint, src/drivers/android/input/device-input, src/http/openapi, src/daemon/input-lease.e2e. Left for the next run: the other 153 changed test files.

Counts: 150 Haiku candidates in 15 files, 109 non-KEEP verdicts after Sonnet verification (+2 from the clean sample), 41 KEEP. Haiku coverage: every line of all 15 files read; scans of main/server/edge/dispatcher did not read all module manuals.
Clean sample: week 44 -> src/daemon/input-lease.e2e, src/ports/service-manager, src/spec-lint (commit 6316e10). Sonnet found 1 candidate (spec-lint:337, confirmed TABLE) = 1 confirmed miss. Because of that, the remaining clean file src/updater/index was scanned with Sonnet: 1 candidate (updater:752, confirmed FIX). 0 further misses.

Test counts (before -> after): cli 384->380, daemon/main 151->149, daemon/server 137->133, agent-device/edge 229->225, drivers/ios 195->192, leasing/create-leasing 184->183, http/app 180->172, gateway/dispatcher 91->93, updater 31->32, queries 18->18, spec-lint 51->51, android device-input 4->4. Net -23 tests.

Applied verdicts: DELETE/MERGE/TABLE collapse duplicate or data-only tests (cli, main, server, edge, ios, leasing, app, dispatcher); FIX adds a missing assertion proven by a temporary source break, or narrows a title (log-only or vacuous claims). Per-file detail is in the commit's diff.

Verifier-rejected findings (KEEP): 31 of 140 — mostly DUP/SUBSUMED (tests assert more than the named twin), LOG (log line documented in the website docs), INTERNAL/COUNT (fake-port records are output), and tests added by fix commits (#42, #102, #224, #268).

bugs:

  • src/cli/index.test.ts:3232 (gateway start with failing config.json) — verifier's toBe(2) fails on unchanged source, which exits 1; the sibling config-set case expects 2. Is 1 or 2 intended? Original not.toBe(0) kept.
  • src/cli/index.test.ts:3320 (--local daemon start joined-worker HTTP conflict) — exits 1, a "usage refusal" per its message. Is 1 or 2 intended? Original not.toBe(0) kept.

Source untouched. Left open for the maintainer because of the bugs: lines.

Written by an agent.


Generated by Claude Code

@V3RON
V3RON marked this pull request as ready for review October 29, 2026 18:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants