Repository navigation
Merged
Conversation
…e verifying the removal
…nup and the case-insensitive state
…etail out of the core constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #259
simctl runtime deletecan answer whilesimctl runtime liststill shows the image as deleting. The iOS driver checked once, at once, so the removal failed although the runtime was gone seconds later.The iOS
removenow lists again every second, on theClock, while the image is in the deleting state:removedwith itsresidue;COMPONENT_REMOVAL_TIMEOUT_MS, measured from the start of the delete and never reset, or whensignalfires:DriverCrashError, and the record is kept.isBeingDeletedis the one place that reads the state. It compares it todeletingignoring case. The exact JSON value still needs confirming on real hardware. Nobody has capturedsimctl runtime list -jduring a delete. The text listing prints(Deleting), and an installed image has"state": "Ready".docs/CLI.mdnow says that the removal waits, and when it gives up.Checklist
component removeon iOS reports an error although the runtime is removed, because simctl lists it as Deleting for a few seconds #259)".pnpm checkis green.Review
Spec review: 8 findings, 2 fixed. Code review: 7 findings, 6 fixed.
Rejected:
statevalue is unconfirmed — true, and it cannot be confirmed without a real delete. The maintainer checks it on hardware after the merge.docs/CLI.mdwas not asked for — the removal can now take longer and fail in a new way. The deliver rules require the user docs to say so.simctl runtime listcall already running is not cut short by the deadline or the signal, so the bound is up to 30 s past five minutes — the wait is still bounded, and the budget is still never reset. The core's own check after the removal runs the same listing. The driver comment and the CLI doc ("about five minutes") say this.Written by an agent.