Repository navigation
Conversation
Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
…wser-cdp-preparation
Co-authored-by: Codex
Co-authored-by: Codex
Co-authored-by: Codex
Co-authored-by: Codex
Co-authored-by: Codex
|
Head |
|
Review at 745fff4: PASS (A-). Control-only smoke gated; 3 tampers caught; CI green. |
Preserve the existing review history and include current develop 8ea4aac. Refresh through the reviewed parent branch where that dependency applies. Co-authored-by: Codex
Apply the test-only System fixture from 619c096 to the refreshed develop base. Preserve the existing authority assertions and production behavior. Co-authored-by: Codex
Preserve the existing review history and include current develop 8ea4aac. Refresh through the reviewed parent branch where that dependency applies. Co-authored-by: Codex
Preserve the existing review history and include current develop 8ea4aac. Refresh through the reviewed parent branch where that dependency applies. Co-authored-by: Codex
Preserve the reviewed task changes and integrate the current development base through a normal merge. Co-authored-by: Codex
Preserve the reviewed task changes and integrate the current development base through a normal merge. Co-authored-by: Codex
Preserve the reviewed task changes and integrate the current development base through a normal merge. Co-authored-by: Codex
Use the upstream Library fixture and preserve the branch feature changes. Co-authored-by: Codex
Use the upstream Library fixture and preserve the branch feature changes. Co-authored-by: Codex
Use the upstream Library fixture and preserve the branch feature changes. Co-authored-by: Codex
|
Ready for Claude review at |
|
Round 6 at d45d7e8: PASS (A-). Body states adapter_cleanup_verified:false; real control-only smoke passes. |
Keep cache invalidation with connection setup and preserve closed-client guards. Co-authored-by: Codex
|
Updated head: |
|
Independent review (Claude) at 5fc7165: PASS (A). Redundant reset in close() removed; connect() still resets readiness; closed-client guards remain. |
Co-authored-by: Codex
Preserve the reviewed input behavior and include current develop through the Browser lifecycle parent. Co-authored-by: Codex
Preserve the reviewed behavior and integrate the verified base through the named parent. Co-authored-by: Codex
|
Updated head: |
CDP Page/Runtime preparation is shared within each connection. Connection failure or replacement invalidates the matching work. Runtime retains authority over effects.
This cleanup removes the redundant readiness reset in
CdpClient.close(). Connection invalidation, reconnect checks and closed-client guards remain.The behavior gate exercises:
The fixture retains production relay filtering. Its
adapter_cleanup_verified:falseresult leaves adapter cleanup as a separate acceptance gate. At prior head5fc71653, all 16 preparation regressions, both runner checks and the control-only smoke passed in each required local gate.Depends on #421 and #420; preserve their ancestry, shared runner additions and inherited Library Home-link fixture.
Candidate:
1a5770f09df24dac18024ac712a0d969b0e30bed; merged #421:bf519a7f824579b1fef1460f9e15555cdd83ef0c, includingdevelopc97c549e20e0851b417447af9509b25a30c23f06. Required local checks: manualjust ci-local-prepushand actual unchanged push hook PASS. Hosted CI: PASS, with 15 successful jobs and one configured skip.Prior-head Claude review records PASS at
5fc71653. Independent source-continuity review passed: all 18 owned path contents match the prior reviewed head. The current-head Claude re-review records PASS at1a5770f0; the linked earlier verdict remains historical evidence. Installed Browser/media and adapter cleanup acceptance remains pending.A separate same-head TAP run passed all 78 input-surface tests, supplementing partial named reporting in the gates. The hook checked later develop
3a043849compatibility.Review order: #420 → #421 → #424 → #416 → #411 → #412 → #428. #417 owns ZIP remediation. Draft; target
develop.