Skip to content

Share CDP domain preparation within each connection - #424

Draft
SashaMIT wants to merge 26 commits into
developfrom
fix/review-browser-cdp-preparation
Draft

SashaMIT wants to merge 26 commits into
developfrom
fix/review-browser-cdp-preparation

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

CDP Page/Runtime preparation is shared within each connection. Connection failure or replacement invalidates the matching work. Runtime retains authority over effects.

This cleanup removes the redundant readiness reset in CdpClient.close(). Connection invalidation, reconnect checks and closed-client guards remain.

The behavior gate exercises:

bash scripts/browser-selkies-control-service-smoke.sh --control-only
node --test scripts/browser-cdp-behaviour-runner.test.mjs

The fixture retains production relay filtering. Its adapter_cleanup_verified:false result leaves adapter cleanup as a separate acceptance gate. At prior head 5fc71653, all 16 preparation regressions, both runner checks and the control-only smoke passed in each required local gate.

Depends on #421 and #420; preserve their ancestry, shared runner additions and inherited Library Home-link fixture.

Candidate: 1a5770f09df24dac18024ac712a0d969b0e30bed; merged #421: bf519a7f824579b1fef1460f9e15555cdd83ef0c, including develop c97c549e20e0851b417447af9509b25a30c23f06. Required local checks: manual just ci-local-prepush and actual unchanged push hook PASS. Hosted CI: PASS, with 15 successful jobs and one configured skip.

Prior-head Claude review records PASS at 5fc71653. Independent source-continuity review passed: all 18 owned path contents match the prior reviewed head. The current-head Claude re-review records PASS at 1a5770f0; the linked earlier verdict remains historical evidence. Installed Browser/media and adapter cleanup acceptance remains pending.

A separate same-head TAP run passed all 78 input-surface tests, supplementing partial named reporting in the gates. The hook checked later develop 3a043849 compatibility.

Review order: #420 → #421 → #424 → #416 → #411 → #412 → #428. #417 owns ZIP remediation. Draft; target develop.

Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
@SashaMIT

Copy link
Copy Markdown
Contributor Author

Independent review (Claude) of ab90ce1: PASS. CDP preparation is per connection, failures retry, and the tamper checks fail as expected.
Follow-up: add the control-only Selkies smoke (red on develop since 7aaded6) to a gate.

Copy link
Copy Markdown
Contributor Author

Head 745fff48f0369979162da363eca6d9733e23d284. Ready for Sasha’s Claude review of this head.
The control-only Selkies process smoke now runs in the behavior gate; proof: node --test scripts/browser-cdp-behaviour-runner.test.mjs, its removed-call check, and bash scripts/browser-selkies-control-service-smoke.sh --control-only.
CI started: https://github.com/Elacity/elastos-runtime/actions/runs/39056287214. Release-path checks passed; other checks remain pending.

@SashaMIT

Copy link
Copy Markdown
Contributor Author

Review at 745fff4: PASS (A-). Control-only smoke gated; 3 tampers caught; CI green.
Body: state adapter_cleanup_verified:false as an open gap.

Preserve the existing review history and include current develop 8ea4aac. Refresh through the reviewed parent branch where that dependency applies.

Co-authored-by: Codex
Apply the test-only System fixture from 619c096 to the refreshed develop base. Preserve the existing authority assertions and production behavior.

Co-authored-by: Codex
Preserve the existing review history and include current develop 8ea4aac. Refresh through the reviewed parent branch where that dependency applies.

Co-authored-by: Codex
Preserve the existing review history and include current develop 8ea4aac. Refresh through the reviewed parent branch where that dependency applies.

Co-authored-by: Codex
Preserve the reviewed task changes and integrate the current development base through a normal merge.

Co-authored-by: Codex
Preserve the reviewed task changes and integrate the current development base through a normal merge.

Co-authored-by: Codex
Preserve the reviewed task changes and integrate the current development base through a normal merge.

Co-authored-by: Codex
Use the upstream Library fixture and preserve the branch feature changes.

Co-authored-by: Codex
Use the upstream Library fixture and preserve the branch feature changes.

Co-authored-by: Codex
Use the upstream Library fixture and preserve the branch feature changes.

Co-authored-by: Codex

Copy link
Copy Markdown
Contributor Author

Ready for Claude review at d45d7e80074d2e3d197ccb27775377549f233689.
Merged current develop; bash scripts/browser-selkies-control-service-smoke.sh --control-only passed in both required local checks, with adapter_cleanup_verified:false.
CI has started: https://github.com/Elacity/elastos-runtime/actions/runs/39100191838

@SashaMIT

Copy link
Copy Markdown
Contributor Author

Round 6 at d45d7e8: PASS (A-). Body states adapter_cleanup_verified:false; real control-only smoke passes.
Optional: the cache reset in CdpClient.close() is unobservable; remove it or add a test.

Keep cache invalidation with connection setup and preserve closed-client guards.

Co-authored-by: Codex

Copy link
Copy Markdown
Contributor Author

Updated head: 5fc716534b32f39974453491f28cf76d1cc5c469.
Unchanged manual and push-hook gates passed, including CDP preparation regressions and the control-only smoke.
CI has started: https://github.com/Elacity/elastos-runtime/actions/runs/39141980417

@SashaMIT

Copy link
Copy Markdown
Contributor Author

Independent review (Claude) at 5fc7165: PASS (A). Redundant reset in close() removed; connect() still resets readiness; closed-client guards remain.
16/16 CDP preparation tests pass; removing the connect() reset fails 3. CI green.

Preserve the reviewed input behavior and include current develop through the Browser lifecycle parent.

Co-authored-by: Codex
Preserve the reviewed behavior and integrate the verified base through the named parent.

Co-authored-by: Codex

Copy link
Copy Markdown
Contributor Author

Updated head: 1a5770f09df24dac18024ac712a0d969b0e30bed.
Manual just ci-local-prepush and the actual unchanged push hook: PASS; separate same-head input-surface TAP proof: 78/78 passed.
CI has started: https://github.com/Elacity/elastos-runtime/actions/runs/39233247017. Source-continuity review: PASS; Claude PASS remains at prior head 5fc71653.

@SashaMIT

Copy link
Copy Markdown
Contributor Author

Re-review (Claude) at 1a5770f: PASS (A carried). One clean merge of #421; empty remerge-diff, own patch unchanged; all CI jobs pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants