Skip to content

Keep Library navigation, uploads and rendering coherent under load - #428

Draft
SashaMIT wants to merge 19 commits into
developfrom
fix/review-library-efficiency
Draft

Keep Library navigation, uploads and rendering coherent under load#428
SashaMIT wants to merge 19 commits into
developfrom
fix/review-library-efficiency

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Library keeps selection, focus and menus coherent during rendering and navigation. Explicit selection owns Delete, Enter, F2 and ContextMenu; focus is the fallback when selection is empty. Runtime owns effects.

Chromium smokes check the initial tab order before row focus. Small and chunked text-row fixtures require the first rendered row to be the sole sequential tab stop. Existing keyboard and rendering checks remain.

node scripts/library-menu-smoke.mjs
node scripts/library-performance-smoke.mjs

At prior head 0f6ad1e5, both Chromium smokes and all 45 owned Node tests passed. A boot-reset mutation failed the intended assertion; exact source restoration passed.

The upload slice is in develop; remaining scope covers selection/action routing, collator reuse, navigation, rendering, smokes and the guide. This PR merges #411 at 898ef790 and inherits its bridge work. Merge last: the guide requires #420/#416/#411/#412. Coordinate #425–#427. #441 owns search-hidden selection/Delete; #67 owns Library images/wallpaper and image-heavy evidence.

Candidate: dcdd115acad78201d845c603a107c1c0084b1d86; merged develop: 3a043849e2c91af3fd338def86d1e3a76d74e701. Required local checks: same-head manual recheck just ci-local-prepush and actual unchanged push hook PASS, including 45 Library tests and both Chromium smokes in each gate. The first manual attempt stopped at the base-stability guard after develop moved. Local execution used this candidate tree; compatibility with later develop at 3beb8164 passed the unchanged disjoint-merge guard separately. Hosted CI: PASS, with all 18 jobs successful.

Prior-head Claude review records PASS (A) at 0f6ad1e5. Independent source-continuity review passed: 20 of 21 owned paths are unchanged; justfile adds only develop’s Home Assistant test invocation, with its remaining bytes preserved. The current-head Claude re-review records PASS at dcdd115a; the linked earlier verdict remains historical evidence. When integrating this PR, preserve both its scripts/test-behaviour.sh additions and #420’s additions. Installed Library performance and authority acceptance remain pending.

Review order: #420 → #421 → #424 → #416 → #411 → #412 → #428. #417 owns ZIP remediation. Draft; target develop.

@elacity2822-beep
fix(library): preserve responsive listings and owned user interactions
58ef539 
Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
@elacity2822-beep
perf(browser): reclaim completed guest control bridge workers
fd5b6e8 
Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
@elacity2822-beep
test(library): wait for typed folder metadata before menu checks
bcb9aea
@elacity2822-beep
test(library): await exact copy dispatch before asserting destinations
ba0194b
@elacity2822-beep
fix(browser): preserve fail-fast bridge shutdown after worker reaping
557cdd3
@elacity2822-beep
Merge commit '63f57e34147f38a4c110716d8f1bfaf24b51d81e' into fix/revi…
70cbe36 
…ew-library-efficiency
@elacity2822-beep
docs: bind regression guidance to exercised runtime behavior
589e46a
@SashaMIT

SashaMIT commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Independent review (Claude) of 589e46a: FAIL. Delete, Enter and F2 act on the focused row instead of the selection: after a Ctrl-click deselect, Delete trashes the deselected item (events.js:308-312; reproduced; develop is correct).
Also: scripts/README.md lines 111-131 and 212-214 describe #412/#416/#411 behaviour that develop does not have yet.

This was referenced Oct 17, 2026
Draft
Draft
Draft
Draft
Draft
@SashaMIT
Merge current develop into Browser bridge review branch
087b89c 
Co-authored-by: Codex
@SashaMIT
Use a platform-neutral app in Home link regression
619c096 
Use the installed System fixture for valid and invalid Home-link requests so the test exercises link authority on every host. Keep all assertions and production launch checks unchanged.

Verified the exact Home-link test passes, reverting only the System token to Browser fails the intended 403-versus-200 assertion, and restoring the fixture passes again.

Co-authored-by: Codex
@SashaMIT SashaMIT mentioned this pull request Oct 17, 2026
Draft
@SashaMIT
Merge reviewed Browser bridge fixes into Library review branch
a2c2215 
Reuse the published Browser bridge prerequisite and its platform-neutral Home-link fixture so Library tests cover the current develop integration. Preserve all Library-owned paths byte-for-byte and retain both branch histories.

Co-authored-by: Codex
@andersalm andersalm mentioned this pull request Oct 17, 2026
Open
9 tasks
@SashaMIT

SashaMIT commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Review at a2c2215: PASS (B+). Selection fix and collator proven; both Library smokes fixed; 18/18 CI green.
Trial merge of all 7 conflicts only in test-behaviour.sh/.test.mjs, as predicted.

@SashaMIT SashaMIT mentioned this pull request Oct 18, 2026
Open
@andersalm

andersalm commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

For 0.8.0: OMP took only this PR's upload fix into the release candidate, unchanged: the capsules/library/browser/src/actions.js upload hunk and actions-upload.test.mjs from a2c221522, as commit 0dbba668b on release/train-0.8.0-rc8. On the candidate, navigating during a multi-file upload sent the remaining files to the new folder, where same-named files were replaced. Your test fails 5 of 6 on the old code and passes 6 of 6 with the fix; Codex reviewed it (PASS). The rest of #428 stays after 0.8.0. When it merges, the upload hunk will already be identical on develop.

andersalm added a commit that referenced this pull request Oct 18, 2026
@andersalm
library: an upload batch stays in the folder chosen when it started (…
0dbba66 
…from #428)

uploadFiles built each file's destination from the folder open when
that file began, so navigating during a multi-file upload sent the rest
to the new folder, where a same-named file was replaced. The batch now
binds its destination at start and keeps its own rows, so overlapping
batches no longer share progress or cleanup.

Cherry-picked unchanged from SashaMIT's #428 at a2c2215 (actions.js
hunk and actions-upload.test.mjs only).
@SashaMIT

SashaMIT commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Round 6 at 0a9b04d: PASS (A-). #441 opened; the seven-PR stack merges with only the known test-runner union; 1,928 behaviour tests pass.
Merge last. Optional: add a tab-stop check before any row has focus.

@SashaMIT
Verify Library tab order before row focus
0f6ad1e 
Assert the initial sole row tab stop in small and chunked fixtures before any focus handler can repair it.

Co-authored-by: Codex
@SashaMIT ChatGPT Codex Connector

SashaMIT commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Updated head: 0f6ad1e5e1580b4a5a8020a1478541e57ef22081.
Unchanged manual and push-hook gates passed; the initial tab-stop control failed as intended and passed after restoration.
CI has started: https://github.com/Elacity/elastos-runtime/actions/runs/39144900918

@andersalm andersalm mentioned this pull request Oct 18, 2026
Open
5 tasks
@SashaMIT

SashaMIT commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Independent review (Claude) at 0f6ad1e: PASS (A). Small and chunked folders now check for exactly one row tab stop before any row has focus.
Both Chromium smokes pass; removing or duplicating the initial tab stop fails the new assertion. CI green.

@SashaMIT
Merge current develop into Browser bridge review
898ef79 
Preserve the reviewed behavior and integrate the verified base through the named parent.

Co-authored-by: Codex
@SashaMIT
Merge refreshed Browser bridge into Library review
dcdd115 
Preserve the reviewed behavior and integrate the verified base through the named parent.

Co-authored-by: Codex
@SashaMIT ChatGPT Codex Connector

SashaMIT commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Updated head: dcdd115acad78201d845c603a107c1c0084b1d86.
Manual recheck just ci-local-prepush and the actual unchanged push hook: PASS, including 45 Library tests and both Chromium smokes in each gate.
CI has started: https://github.com/Elacity/elastos-runtime/actions/runs/39262380409. Current-head source-continuity review: PASS; Claude PASS (A) remains at prior 0f6ad1e5, with new-head review pending.

@SashaMIT

SashaMIT commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Re-review (Claude) at dcdd115: PASS (A carried). One clean merge of #411; own patch unchanged.
CI run 39262380409 was still running at review time; the test-behaviour union with #420 is still needed in the chain.

@SashaMIT SashaMIT mentioned this pull request Oct 19, 2026
Open
@andersalm andersalm mentioned this pull request Oct 22, 2026
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SashaMIT @andersalm @elacity2822-beep