You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Explain EXCLUDED_LANGS casing or make it case-insensitive #64
The current implementation expects the languages to be in the same style as displayed on GitHub e.g.
HTML, not html
Ruby, not ruby
My first instict when I set up EXCLUDED_LANGS was to make something like html,tex. Not until reading the source code I saw that the code expects the exclude list to be using the same casing as GitHub has. Thus to exclude HTML and Tex files, we must write HTML,TeX.
I propose one of these:
We make the lookup case-insensitive i.e. normalize both each repo's languages and the user's set EXCLUDED_LANGS to lower-case.
If not, we should explain in the README that the EXCLUDED_LANGS should have languages as displayed in the generated image / as shown on the GitHub repo page
Activity
jstrieb commentedon Feb 15, 2022
Hey @erikw, thanks for the suggestion! I wholeheartedly agree that it should be a case-insensitive check. This is a good catch.
Feel free to make a PR, otherwise I can push this change at some point.
Normalize excluded languages comparison
Normalize excluded languages comparison
Normalize excluded languages comparison
Normalize excluded languages comparison