Skip to content

Normalize excluded languages comparison - #65

Merged
jstrieb merged 2 commits into
jstrieb:masterfrom
erikw:fix/64
Feb 17, 2022
Merged

jstrieb merged 2 commits into
jstrieb:masterfrom
erikw:fix/64

Conversation

@erikw

@erikw erikw commented Feb 16, 2022 •

Copy link
Copy Markdown
Contributor

It's not clear for users how the EXCLUDED_LANGS secret should be populated:

  • html,tex
  • HTML,TeX
    ?

Avoid all question marks by normalizing both strings to
lower case before they are compared.

I tried this and it worked for me!

Fixes #64

erikw and others added 2 commits February 16, 2022 20:13
It's not clear for users how the EXCLUDED_LANGS should be populated:
* html,tex
* HTML,TeX
?

Avoid all question marks by normalizing both strings to
lower case before they are compared.

Fixes jstrieb#64
@jstrieb
jstrieb merged commit 29e6b60 into jstrieb:master Feb 17, 2022
@erikw
erikw deleted the fix/64 branch February 17, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explain EXCLUDED_LANGS casing or make it case-insensitive

2 participants