Repository navigation
deps: bump minimatch from 4.2.1 to 5.0.0 - #25
Merged
Merged
Conversation
Bumps [minimatch](https://github.com/isaacs/minimatch) from 4.2.1 to 5.0.0. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Commits](isaacs/minimatch@v4.2.1...v5.0.0) --- updated-dependencies: - dependency-name: minimatch dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
|
Breaking change is the path separator, and this repo is moving pretty fast this week. Let's wait a few days, if we can do this at all. |
Contributor
|
hmmmm it looks like that change has potential to be disruptive, maybe we should validating values here (in this module) so that we can start throwing a more user-friendly error when finding backward-slashes? 🤔 |
Contributor
|
or you know, we just do the conversion prior to any call to |
Contributor
|
It doesn't currently work with backslashes so we're good! ~/D/n/scratch $ cat workspaces/a/package.json
{
"name": "workspace-a",
"version": "1.0.0"
}
~/D/n/scratch $ npm pkg get workspaces
"workspaces\\a"
~/D/n/scratch $ npm ls -ws
npm ERR! No workspaces found!
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/wraithgar/.npm/_logs/2022-02-16T17_14_26_815Z-debug-0.log |
This was referenced Feb 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps minimatch from 4.2.1 to 5.0.0.
Commits
fc44f5f5.0.09104d8dExpect exclusively forward slash as path sep, same as node-glob58b72d3fix(brace-expansion): ignore only blocks that begins with $Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)