Repository navigation
fix: normalize backslashes - #26
Merged
Merged
Conversation
Contributor
Author
|
This shows that #25 can merge as-is |
wraithgar
force-pushed
the
gar/normalize-glob
branch
from
February 16, 2022 17:29
6b25cd3 to
8b2d1a9
Compare
Contributor
Author
|
Good thing we tested this, looks like we should normalize what minimatch removed. |
wraithgar
force-pushed
the
gar/normalize-glob
branch
from
February 16, 2022 17:56
8b2d1a9 to
b60a80e
Compare
The next semver-major of minimatch does not allow backslashes. We'll normalize it here so that change doesn't break anyone currently relying on that behavior.
wraithgar
force-pushed
the
gar/normalize-glob
branch
from
February 16, 2022 18:01
b60a80e to
2af5f83
Compare
ruyadorno
reviewed
Feb 16, 2022
ruyadorno
approved these changes
Feb 17, 2022
This was referenced Feb 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next semver-major of minimatch does not allow backslashes. We'll
normalize it here so that change doesn't break anyone currently relying
on that behavior