Skip to content

ci: harden release pipeline dependencies, wheel builds, and checkout credentials - #5884

Open
DylanRussell wants to merge 11 commits into
open-telemetry:mainfrom
DylanRussell:release_improvements
Open

DylanRussell wants to merge 11 commits into
open-telemetry:mainfrom
DylanRussell:release_improvements

Conversation

@DylanRussell

Copy link
Copy Markdown
Contributor

Description

Applies the remaining release pipeline hardening changes from open-telemetry/opentelemetry-python-genai#978:

  • Set minimumReleaseAge: "3 days" in .github/renovate.json5 and use uv with --exclude-newer 3d / UV_EXCLUDE_NEWER=3d across release workflows and scripts.
  • Verify a clean git working tree before building and audit built wheel contents in scripts/build.sh.
  • Set persist-credentials: false on remaining actions/checkout steps in release/backport workflows and authenticate pushes via gh auth setup-git.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • I am a human and not a bot
  • I have run tox -e precommit
  • I have run tox -e typecheck
  • I have run the relevant tests and linting tox environments

@DylanRussell
DylanRussell requested a review from a team as a code owner November 4, 2026 14:33
@DylanRussell DylanRussell added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 4, 2026
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-11-13 15:00 UTC

Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):

  • Top-level threads: 1
Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

Comment thread .github/scripts/update-version-patch.sh Resolved

@emdneto emdneto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has some pieces in common with https://github.com/open-telemetry/opentelemetry-python/pull/5837/changes. Maybe we can merge merge #5837 first and implement your changes

Comment thread .github/scripts/update-version-patch.sh Resolved
Comment thread .github/workflows/release.yml Resolved
@github-project-automation github-project-automation Bot moved this to Approved PRs in Python PR digest Nov 10, 2026
Comment thread scripts/build.sh Resolved
Comment thread scripts/build.sh Resolved
@aabmass
aabmass requested review from aabmass and a balanced review from Copilot November 10, 2026 22:10
@aabmass

aabmass commented Nov 10, 2026

Copy link
Copy Markdown
Member

I think this has some pieces in common with https://github.com/open-telemetry/opentelemetry-python/pull/5837/changes. Maybe we can merge merge #5837 first and implement your changes

Agreed, @DylanRussell do you mind reviewing #5837?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Active findings identify a path-traversal bypass in the build audit, exposure of write-scoped credentials to dependency execution, and incomplete enforcement of the dependency release-age cutoff.

3 open issues
What changed in this PR

This PR hardens OpenTelemetry Python’s release tooling by restricting dependency freshness, checking build inputs and wheel contents, and reducing stored checkout credentials.

Changes:

  • Adds a three-day Renovate update delay and a uv build dependency cutoff.
  • Moves release tooling to locked uv dependencies and adds clean-tree and wheel-content checks.
  • Disables checkout credential persistence and authenticates pushes through GitHub CLI.
File Description
uv.lock Locks added release tools and their dependencies.
scripts/​build.sh Uses uv builds with freshness, clean-tree, and wheel-content checks.
pyproject.toml Adds toml and twine development dependencies.
.github/​workflows/​release.yml Runs version discovery and publishing through uv.
.github/​workflows/​prepare-release-branch.yml Uses uv tooling and explicit push authentication.
.github/​workflows/​prepare-patch-release.yml Updates patch preparation tooling and authentication.
.github/​workflows/​backport.yml Removes persisted credentials and adjusts authentication permissions.
.github/​scripts/​update-version.sh Runs version updates through locked uv dependencies.
.github/​scripts/​update-version-patch.sh Uses uv and quotes version arguments.
.github/​renovate.json5 Adds a three-day minimum release age for updates.

Review effort: Balanced

Comment thread scripts/build.sh Resolved
Comment thread scripts/build.sh Resolved
@opentelemetry-pr-dashboard

Copy link
Copy Markdown

Hi @DylanRussell — just a friendly reminder that this pull request is waiting on you. The dashboard status comment has the open items and is kept current.

  • Replying is enough to hand it off — answer, explain why no change is needed, or ask a follow-up. The dashboard routes it onward once nothing on the list is waiting on you.
  • To hand it back for any other reason, including the dashboard getting this wrong, comment /dashboard route:reviewers.

@DylanRussell

Copy link
Copy Markdown
Contributor Author

Ack added my review to g #5837 .. We can wait for that

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Approved PRs

Development

Successfully merging this pull request may close these issues.

5 participants