Skip to content

Reclassify HolidayLights as an Operational Config Repo - #3453

Merged
ptr727 merged 3 commits into
developfrom
registry/holidaylights-operational
Oct 25, 2026
Merged

ptr727 merged 3 commits into
developfrom
registry/holidaylights-operational

Conversation

@ptr727

@ptr727 ptr727 commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Reclassifies HolidayLights in registry/repos.json to match what the repo now is. It is being stood up against the hub in ptr727/HolidayLights#13 through #16.

Changes

  • workflowModel: operational, plus groundTruthBranch: main and lineEndings: lf. xLights edits the show folders in place on develop, the same shape as Vantage-Config and HomeAssistant-Config. The repo was on release only by default.
  • releaseTrigger: dispatch-only with publish: [{ github-release, none }]. The maintainer wants a source-code release only, with no render or validation in CI. This was none, with no publish targets.
  • description, which the README tagline mirrors (ptr727/HolidayLights#16).
  • driftNotes: replaces the stale "main is near-empty" and "No CI/governance scaffolding" notes. The new notes record:
    • .fseq renders are tracked.
    • xLights save backups, Backup/ folders, and FPP controller exports stay local.
    • The effect-presets CRLF pin (ptr727/HolidayLights#10).
    • A rename to HolidayLights-Config is planned.

Verification

  • spec/validate.py classifies all 22 cataloged repos cleanly.
  • The prose gate passes on the diff, and repo_gate.py --check eol reports no issues.

🤖 Generated with Claude Code

HolidayLights holds xLights show folders that xLights edits in place on
develop and FPP Connect uploads to the controllers, so it follows the
operational model the other config repos use: lineEndings lf, a
dispatch-only source release to GitHub, and the registry description its
README tagline now mirrors.

Replace the stale driftNotes ("main is near-empty", "No CI/governance
scaffolding") with what the repo is: tracked .fseq renders, local-only
xLights and FPP backups, the effect-presets CRLF pin from
ptr727/HolidayLights#10, and the planned rename to HolidayLights-Config.
Copilot AI lite review requested due to automatic review settings October 25, 2026 03:04
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The drift notes contradict each other on whether the effect-presets .jbkp backup stays local, and the switch to main as ground truth needs the maintainer to confirm that main has been promoted.

2 open issues
What changed in this PR

This PR updates the HolidayLights entry in registry/repos.json. It moves the repo from a cataloged source-only repo with no release to an operational config repo, matching the pattern used by Vantage-Config and HomeAssistant-Config. It is being stood up against the hub in ptr727/HolidayLights#13 through #16.

Changes:

  • Sets workflowModel to operational, groundTruthBranch to main, and lineEndings to lf.
  • Changes releaseTrigger to dispatch-only and sets publish to a GitHub release with no render or validation step.
  • Adds a description and replaces the old drift notes with notes on tracked .fseq renders, local-only backups, the effect-presets CRLF pin, and the planned rename to HolidayLights-Config.
File Description
registry/​repos.json Reclassifies the HolidayLights entry as an operational config repo with dispatch-only release, LF default, and updated description and drift notes.

Review effort: Lite

Comment thread registry/repos.json Resolved
Comment thread registry/repos.json Resolved
main holds the 2021-2024 show folders and the original lint gate, while the
2025 and 2026 folders and the fleet baseline wait on develop for a
promotion, so the entry says so rather than reading as current. The
effect-presets .jbkp backup is gitignored, so the CRLF note names only the
tracked xlights_effectpresets.json.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The change redefines the audited ground-truth branch for a live repo whose main still lacks its 2025 and 2026 show folders, and that promotion's state could not be verified from this review.

No open issues 🎉

2 resolved since last review

Review effort: Lite

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@74eb906). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3453   +/-   ##
==========================================
  Coverage           ?   80.78%           
==========================================
  Files              ?       23           
  Lines              ?     8840           
  Branches           ?        0           
==========================================
  Hits               ?     7141           
  Misses             ?     1699           
  Partials           ?        0           
Flag Coverage Δ
python-3.13 80.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Answering the headline ("redefines the audited ground-truth branch for a live repo whose main still lacks its 2025 and 2026 show folders"): the entry does not change the ground-truth branch. groundTruthBranch was absent before, and the registry default is main, so the audit already measured main. Declaring it makes the default explicit, matching the other operational config repos. The promotion state is now recorded as a driftNote (1c9297b): main carries the 2021-2024 show folders and the original lint gate, and the 2025 and 2026 folders and the fleet baseline wait on develop (ptr727/HolidayLights#11, #13-#16) for a develop->main promotion, so an audit of main reads those findings as the pending promotion. That driftNote is deleted in the change that records the promotion.

The repo's committed xLights networks include a WLED controller, so the
description its README tagline mirrors names it beside FPP.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The entry changes the branch the audit measures for a live repo, and its accuracy depends on a develop-to-main promotion that cannot be verified from this checkout.

No open issues 🎉

Review effort: Lite

@ptr727

ptr727 commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Answering the headline on f20a543 ("changes the branch the audit measures ... depends on a develop-to-main promotion"): as answered on 1c9297b, the audited branch does not change. groundTruthBranch was absent and the registry default is main, so declaring it only makes the default explicit. The pending promotion is recorded in the driftNote that names it, which the promotion change deletes.

@ptr727
ptr727 merged commit ccc5db3 into develop Oct 25, 2026
14 checks passed
@ptr727
ptr727 deleted the registry/holidaylights-operational branch October 25, 2026 04:20
ptr727 added a commit that referenced this pull request Oct 25, 2026
…nd Nine Fixes to Main (#3472)

## Summary

Promotes the pull requests merged into develop since release 2.0.1166.

- [#3444](#3444): keeps
untracked files out of the pre-commit snippet's prose gate.
- [#3446](#3446): exempts
the BuildKit `check=` parser directive in the prose gate.
- [#3448](#3448): compares
intent staleness against the hub's own copy and names the moved
canonical.
- [#3450](#3450): says
only the prose gate is diff-scoped in the commit hook.
- [#3453](#3453):
reclassifies HolidayLights as an operational config repository in the
registry.
- [#3455](#3455):
classifies the remaining subprocess failures by status rather than by
prose.
- [#3464](#3464): splits
the semicolon series in WORKFLOW.md's filesystem output-seam bullet.
- [#3466](#3466): audits a
caller's `workflow-model` input against the registry.
- [#3469](#3469): emits
one snapshot shape from the skills report's cannot-read paths.
- [#3462](#3462): splits
`pr_review.py`'s pure check and round readers into the leaf modules
`pr_review_checks.py` and `pr_review_rounds.py`.
- [#3470](#3470): holds a
covered held `wait` while any workflow run on the head has not
completed.
- [#3473](#3473): answers
this promotion's review. The `wait` help and `scripts/README.md` now say
what a held head's exit `0` does not prove: a `CHECKS UNREADABLE`
payload, the conditions the unregistered-required-check hold reads, and
the reach of the completed-run read. The exit code itself stays for
#3471.

Closes #3370
Closes #3372
Closes #3371
Closes #3369
Closes #3378
Closes #3454
Closes #3332
Closes #1759
Closes #3451

## Constituent coverage

Each change this promotion carries had coverage on its own pull request
into develop, at its merged head:

| Pull request | Merged head | Coverage |
| --- | --- | --- |
| [#3444](#3444) |
`a61d1e2a` | attested local pass at the merged head, base `develop` |
| [#3446](#3446) |
`0a0efea1` | attested local pass at the merged head, base `develop` |
| [#3448](#3448) |
`c2c71ea7` | attested local pass at the merged head, base `develop` |
| [#3450](#3450) |
`4ec37c34` | attested local pass at the merged head, base `develop` |
| [#3453](#3453) |
`f20a543c` | a Copilot round on the merged head, its one changed file,
no open findings |
| [#3455](#3455) |
`85f0ce60` | attested local pass at the merged head, base `develop` |
| [#3464](#3464) |
`fcd48e2d` | attested local pass at the merged head, base `develop` |
| [#3466](#3466) |
`3426a19c` | attested local pass at the merged head, base `develop` |
| [#3469](#3469) |
`ea4b0bb7` | attested local pass at the merged head, base `develop` |
| [#3462](#3462) |
`236eceab` | attested local pass at the merged head, base `develop` |
| [#3470](#3470) |
`3545ba46` | attested local pass at the merged head, base `develop` |
| [#3473](#3473) |
`46010530` | attested local pass at the merged head, base `develop`, and
a Copilot table on an earlier head naming exactly the changed files |

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants