Repository navigation
Reclassify HolidayLights as an Operational Config Repo - #3453
Conversation
HolidayLights holds xLights show folders that xLights edits in place on
develop and FPP Connect uploads to the controllers, so it follows the
operational model the other config repos use: lineEndings lf, a
dispatch-only source release to GitHub, and the registry description its
README tagline now mirrors.
Replace the stale driftNotes ("main is near-empty", "No CI/governance
scaffolding") with what the repo is: tracked .fseq renders, local-only
xLights and FPP backups, the effect-presets CRLF pin from
ptr727/HolidayLights#10, and the planned rename to HolidayLights-Config.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟡 Changes recommended
The drift notes contradict each other on whether the effect-presets .jbkp backup stays local, and the switch to main as ground truth needs the maintainer to confirm that main has been promoted.
2 open issues
What changed in this PR
This PR updates the HolidayLights entry in registry/repos.json. It moves the repo from a cataloged source-only repo with no release to an operational config repo, matching the pattern used by Vantage-Config and HomeAssistant-Config. It is being stood up against the hub in ptr727/HolidayLights#13 through #16.
Changes:
- Sets
workflowModeltooperational,groundTruthBranchtomain, andlineEndingstolf. - Changes
releaseTriggertodispatch-onlyand sets publish to a GitHub release with no render or validation step. - Adds a
descriptionand replaces the old drift notes with notes on tracked.fseqrenders, local-only backups, the effect-presets CRLF pin, and the planned rename toHolidayLights-Config.
| File | Description |
|---|---|
| registry/repos.json | Reclassifies the HolidayLights entry as an operational config repo with dispatch-only release, LF default, and updated description and drift notes. |
Review effort: Lite
main holds the 2021-2024 show folders and the original lint gate, while the 2025 and 2026 folders and the fleet baseline wait on develop for a promotion, so the entry says so rather than reading as current. The effect-presets .jbkp backup is gitignored, so the CRLF note names only the tracked xlights_effectpresets.json.
There was a problem hiding this comment.
🔵 Needs a closer look
The change redefines the audited ground-truth branch for a live repo whose main still lacks its 2025 and 2026 show folders, and that promotion's state could not be verified from this review.
No open issues 🎉
2 resolved since last review
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3453 +/- ##
==========================================
Coverage ? 80.78%
==========================================
Files ? 23
Lines ? 8840
Branches ? 0
==========================================
Hits ? 7141
Misses ? 1699
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Answering the headline ("redefines the audited ground-truth branch for a live repo whose main still lacks its 2025 and 2026 show folders"): the entry does not change the ground-truth branch. |
The repo's committed xLights networks include a WLED controller, so the description its README tagline mirrors names it beside FPP.
|
Answering the headline on f20a543 ("changes the branch the audit measures ... depends on a develop-to-main promotion"): as answered on 1c9297b, the audited branch does not change. |
…nd Nine Fixes to Main (#3472) ## Summary Promotes the pull requests merged into develop since release 2.0.1166. - [#3444](#3444): keeps untracked files out of the pre-commit snippet's prose gate. - [#3446](#3446): exempts the BuildKit `check=` parser directive in the prose gate. - [#3448](#3448): compares intent staleness against the hub's own copy and names the moved canonical. - [#3450](#3450): says only the prose gate is diff-scoped in the commit hook. - [#3453](#3453): reclassifies HolidayLights as an operational config repository in the registry. - [#3455](#3455): classifies the remaining subprocess failures by status rather than by prose. - [#3464](#3464): splits the semicolon series in WORKFLOW.md's filesystem output-seam bullet. - [#3466](#3466): audits a caller's `workflow-model` input against the registry. - [#3469](#3469): emits one snapshot shape from the skills report's cannot-read paths. - [#3462](#3462): splits `pr_review.py`'s pure check and round readers into the leaf modules `pr_review_checks.py` and `pr_review_rounds.py`. - [#3470](#3470): holds a covered held `wait` while any workflow run on the head has not completed. - [#3473](#3473): answers this promotion's review. The `wait` help and `scripts/README.md` now say what a held head's exit `0` does not prove: a `CHECKS UNREADABLE` payload, the conditions the unregistered-required-check hold reads, and the reach of the completed-run read. The exit code itself stays for #3471. Closes #3370 Closes #3372 Closes #3371 Closes #3369 Closes #3378 Closes #3454 Closes #3332 Closes #1759 Closes #3451 ## Constituent coverage Each change this promotion carries had coverage on its own pull request into develop, at its merged head: | Pull request | Merged head | Coverage | | --- | --- | --- | | [#3444](#3444) | `a61d1e2a` | attested local pass at the merged head, base `develop` | | [#3446](#3446) | `0a0efea1` | attested local pass at the merged head, base `develop` | | [#3448](#3448) | `c2c71ea7` | attested local pass at the merged head, base `develop` | | [#3450](#3450) | `4ec37c34` | attested local pass at the merged head, base `develop` | | [#3453](#3453) | `f20a543c` | a Copilot round on the merged head, its one changed file, no open findings | | [#3455](#3455) | `85f0ce60` | attested local pass at the merged head, base `develop` | | [#3464](#3464) | `fcd48e2d` | attested local pass at the merged head, base `develop` | | [#3466](#3466) | `3426a19c` | attested local pass at the merged head, base `develop` | | [#3469](#3469) | `ea4b0bb7` | attested local pass at the merged head, base `develop` | | [#3462](#3462) | `236eceab` | attested local pass at the merged head, base `develop` | | [#3470](#3470) | `3545ba46` | attested local pass at the merged head, base `develop` | | [#3473](#3473) | `46010530` | attested local pass at the merged head, base `develop`, and a Copilot table on an earlier head naming exactly the changed files | 🤖 Generated with [Claude Code](https://claude.com/claude-code)


Reclassifies HolidayLights in
registry/repos.jsonto match what the repo now is. It is being stood up against the hub in ptr727/HolidayLights#13 through #16.Changes
workflowModel: operational, plusgroundTruthBranch: mainandlineEndings: lf. xLights edits the show folders in place ondevelop, the same shape as Vantage-Config and HomeAssistant-Config. The repo was onreleaseonly by default.releaseTrigger: dispatch-onlywithpublish: [{ github-release, none }]. The maintainer wants a source-code release only, with no render or validation in CI. This wasnone, with no publish targets.description, which the README tagline mirrors (ptr727/HolidayLights#16).driftNotes: replaces the stale "main is near-empty" and "No CI/governance scaffolding" notes. The new notes record:.fseqrenders are tracked.Backup/folders, and FPP controller exports stay local.HolidayLights-Configis planned.Verification
spec/validate.pyclassifies all 22 cataloged repos cleanly.repo_gate.py --check eolreports no issues.🤖 Generated with Claude Code