Skip to content

Split the Semicolon Series in WORKFLOW.md's Filesystem Output-Seam Bullet - #3464

Merged
ptr727 merged 2 commits into
developfrom
feature/auto-3454
Oct 25, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/auto-3454

Conversation

@ptr727

@ptr727 ptr727 commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Summary

WORKFLOW.md's "Filesystem on a host the project owns" output-seam bullet joined the deploy contract's guarantees into one sentence with semicolons. Each guarantee is now its own sentence, with the meaning unchanged. The Skill distributions are regenerated with scripts/build_dist.py, so .agents/skills/workflow-ci-contract/references/architecture.md, .github/skills/, and .claude-plugin/fleet-skills/ carry the same text.

Closes on promotion: #3454

Why the Prose Gate Passed It

The gate behaved as comment-and-doc-style states the rule, so no gate issue is filed. rule_semicolon in .github/actions/prose-gate/prose_lint.py exempts a sentence holding more than one semicolon that also carries a comma, which is the rule's own exception for a semicolon-separated list whose items contain commas. The old sentence held two semicolons and several commas, so it read as that list. It was a series of three "that" clauses, and the first one carried commas, so the exemption fit its shape. The skip had nothing to do with the word "that" or the bold-led list item. Copilot's downstream finding was a preference for sentences over a semicolon series, and that preference is the better reading here, which is why the text still changes.

Verification

  • git grep -n 'costs nothing;' finds nothing.
  • scripts/build_dist.py --check reports the generated distributions current.
  • scripts/prose_lint.py --diff origin/develop passes on the changed files.
  • Two recorded local-strict-review passes ran. The first found that the recast deploy sentence ran to 35 words, and the second commit splits it. The second pass found nothing this change introduced.

Pre-existing findings, not filed

  • WORKFLOW.md:130, pre-existing: the bullet's opening sentence ("the leaf builds the tree, ships it to the host, and contributes no release-asset-*") runs to 27 words under --check sentence-length. This change did not touch that text.
  • WORKFLOW.md:130, pre-existing: the Retention (D5.6) sentence runs to 39 words under --check sentence-length. This change did not touch that text.

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 24, 2026 21:10
…llet

The bullet joined the deploy contract's three guarantees with semicolons. Each guarantee is now
its own sentence, and the generated Skill distributions are rebuilt to carry the same text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 25, 2026 04:13
@ptr727

ptr727 commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head fcd48e2d19c36fa920ccf71bac2943ba389f0085, the content this pull request carries at that commit against develop, and it recorded 2 findings.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified, and all synchronized generated files were reviewed.

No open issues 🎉

What changed in this PR

This pull request improves the readability of the filesystem deployment contract by replacing a semicolon-separated series with separate sentences while preserving its meaning. The corresponding Skill references and generated distributions are synchronized.

Changes:

  • Rephrases the filesystem output-seam bullet in WORKFLOW.md.
  • Regenerates the authored and distributed workflow-ci-contract architecture references.
  • Updates the generated Skill source digest.
File Description
WORKFLOW.md Updates the canonical filesystem deployment contract wording.
.github/​skills/​workflow-ci-contract/​references/​architecture.md Carries the regenerated GitHub Skill reference.
.claude-plugin/​fleet-skills/​skills/​workflow-ci-contract/​references/​architecture.md Carries the regenerated Claude Skill reference.
.claude-plugin/​fleet-skills/​.source-digests/​workflow-ci-contract Records the updated generated Skill digest.
.agents/​skills/​workflow-ci-contract/​references/​architecture.md Carries the regenerated authored Skill reference.

Review effort: Lite

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@c68367a). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3464   +/-   ##
==========================================
  Coverage           ?   80.89%           
==========================================
  Files              ?       23           
  Lines              ?     8845           
  Branches           ?        0           
==========================================
  Hits               ?     7155           
  Misses             ?     1690           
  Partials           ?        0           
Flag Coverage Δ
python-3.13 80.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit bfd8acb into develop Oct 25, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/auto-3454 branch October 25, 2026 04:24
ptr727 added a commit that referenced this pull request Oct 25, 2026
…nd Nine Fixes to Main (#3472)

## Summary

Promotes the pull requests merged into develop since release 2.0.1166.

- [#3444](#3444): keeps
untracked files out of the pre-commit snippet's prose gate.
- [#3446](#3446): exempts
the BuildKit `check=` parser directive in the prose gate.
- [#3448](#3448): compares
intent staleness against the hub's own copy and names the moved
canonical.
- [#3450](#3450): says
only the prose gate is diff-scoped in the commit hook.
- [#3453](#3453):
reclassifies HolidayLights as an operational config repository in the
registry.
- [#3455](#3455):
classifies the remaining subprocess failures by status rather than by
prose.
- [#3464](#3464): splits
the semicolon series in WORKFLOW.md's filesystem output-seam bullet.
- [#3466](#3466): audits a
caller's `workflow-model` input against the registry.
- [#3469](#3469): emits
one snapshot shape from the skills report's cannot-read paths.
- [#3462](#3462): splits
`pr_review.py`'s pure check and round readers into the leaf modules
`pr_review_checks.py` and `pr_review_rounds.py`.
- [#3470](#3470): holds a
covered held `wait` while any workflow run on the head has not
completed.
- [#3473](#3473): answers
this promotion's review. The `wait` help and `scripts/README.md` now say
what a held head's exit `0` does not prove: a `CHECKS UNREADABLE`
payload, the conditions the unregistered-required-check hold reads, and
the reach of the completed-run read. The exit code itself stays for
#3471.

Closes #3370
Closes #3372
Closes #3371
Closes #3369
Closes #3378
Closes #3454
Closes #3332
Closes #1759
Closes #3451

## Constituent coverage

Each change this promotion carries had coverage on its own pull request
into develop, at its merged head:

| Pull request | Merged head | Coverage |
| --- | --- | --- |
| [#3444](#3444) |
`a61d1e2a` | attested local pass at the merged head, base `develop` |
| [#3446](#3446) |
`0a0efea1` | attested local pass at the merged head, base `develop` |
| [#3448](#3448) |
`c2c71ea7` | attested local pass at the merged head, base `develop` |
| [#3450](#3450) |
`4ec37c34` | attested local pass at the merged head, base `develop` |
| [#3453](#3453) |
`f20a543c` | a Copilot round on the merged head, its one changed file,
no open findings |
| [#3455](#3455) |
`85f0ce60` | attested local pass at the merged head, base `develop` |
| [#3464](#3464) |
`fcd48e2d` | attested local pass at the merged head, base `develop` |
| [#3466](#3466) |
`3426a19c` | attested local pass at the merged head, base `develop` |
| [#3469](#3469) |
`ea4b0bb7` | attested local pass at the merged head, base `develop` |
| [#3462](#3462) |
`236eceab` | attested local pass at the merged head, base `develop` |
| [#3470](#3470) |
`3545ba46` | attested local pass at the merged head, base `develop` |
| [#3473](#3473) |
`46010530` | attested local pass at the merged head, base `develop`, and
a Copilot table on an earlier head naming exactly the changed files |

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants