Repository navigation
Split the Semicolon Series in WORKFLOW.md's Filesystem Output-Seam Bullet - #3464
Conversation
…llet The bullet joined the deploy contract's three guarantees with semicolons. Each guarantee is now its own sentence, and the generated Skill distributions are rebuilt to carry the same text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified, and all synchronized generated files were reviewed.
No open issues 🎉
What changed in this PR
This pull request improves the readability of the filesystem deployment contract by replacing a semicolon-separated series with separate sentences while preserving its meaning. The corresponding Skill references and generated distributions are synchronized.
Changes:
- Rephrases the filesystem output-seam bullet in
WORKFLOW.md. - Regenerates the authored and distributed
workflow-ci-contractarchitecture references. - Updates the generated Skill source digest.
| File | Description |
|---|---|
WORKFLOW.md |
Updates the canonical filesystem deployment contract wording. |
.github/skills/workflow-ci-contract/references/architecture.md |
Carries the regenerated GitHub Skill reference. |
.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/architecture.md |
Carries the regenerated Claude Skill reference. |
.claude-plugin/fleet-skills/.source-digests/workflow-ci-contract |
Records the updated generated Skill digest. |
.agents/skills/workflow-ci-contract/references/architecture.md |
Carries the regenerated authored Skill reference. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3464 +/- ##
==========================================
Coverage ? 80.89%
==========================================
Files ? 23
Lines ? 8845
Branches ? 0
==========================================
Hits ? 7155
Misses ? 1690
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…nd Nine Fixes to Main (#3472) ## Summary Promotes the pull requests merged into develop since release 2.0.1166. - [#3444](#3444): keeps untracked files out of the pre-commit snippet's prose gate. - [#3446](#3446): exempts the BuildKit `check=` parser directive in the prose gate. - [#3448](#3448): compares intent staleness against the hub's own copy and names the moved canonical. - [#3450](#3450): says only the prose gate is diff-scoped in the commit hook. - [#3453](#3453): reclassifies HolidayLights as an operational config repository in the registry. - [#3455](#3455): classifies the remaining subprocess failures by status rather than by prose. - [#3464](#3464): splits the semicolon series in WORKFLOW.md's filesystem output-seam bullet. - [#3466](#3466): audits a caller's `workflow-model` input against the registry. - [#3469](#3469): emits one snapshot shape from the skills report's cannot-read paths. - [#3462](#3462): splits `pr_review.py`'s pure check and round readers into the leaf modules `pr_review_checks.py` and `pr_review_rounds.py`. - [#3470](#3470): holds a covered held `wait` while any workflow run on the head has not completed. - [#3473](#3473): answers this promotion's review. The `wait` help and `scripts/README.md` now say what a held head's exit `0` does not prove: a `CHECKS UNREADABLE` payload, the conditions the unregistered-required-check hold reads, and the reach of the completed-run read. The exit code itself stays for #3471. Closes #3370 Closes #3372 Closes #3371 Closes #3369 Closes #3378 Closes #3454 Closes #3332 Closes #1759 Closes #3451 ## Constituent coverage Each change this promotion carries had coverage on its own pull request into develop, at its merged head: | Pull request | Merged head | Coverage | | --- | --- | --- | | [#3444](#3444) | `a61d1e2a` | attested local pass at the merged head, base `develop` | | [#3446](#3446) | `0a0efea1` | attested local pass at the merged head, base `develop` | | [#3448](#3448) | `c2c71ea7` | attested local pass at the merged head, base `develop` | | [#3450](#3450) | `4ec37c34` | attested local pass at the merged head, base `develop` | | [#3453](#3453) | `f20a543c` | a Copilot round on the merged head, its one changed file, no open findings | | [#3455](#3455) | `85f0ce60` | attested local pass at the merged head, base `develop` | | [#3464](#3464) | `fcd48e2d` | attested local pass at the merged head, base `develop` | | [#3466](#3466) | `3426a19c` | attested local pass at the merged head, base `develop` | | [#3469](#3469) | `ea4b0bb7` | attested local pass at the merged head, base `develop` | | [#3462](#3462) | `236eceab` | attested local pass at the merged head, base `develop` | | [#3470](#3470) | `3545ba46` | attested local pass at the merged head, base `develop` | | [#3473](#3473) | `46010530` | attested local pass at the merged head, base `develop`, and a Copilot table on an earlier head naming exactly the changed files | 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
WORKFLOW.md's "Filesystem on a host the project owns" output-seam bullet joined the deploy contract's guarantees into one sentence with semicolons. Each guarantee is now its own sentence, with the meaning unchanged. The Skill distributions are regenerated withscripts/build_dist.py, so.agents/skills/workflow-ci-contract/references/architecture.md,.github/skills/, and.claude-plugin/fleet-skills/carry the same text.Closes on promotion: #3454
Why the Prose Gate Passed It
The gate behaved as
comment-and-doc-stylestates the rule, so no gate issue is filed.rule_semicolonin.github/actions/prose-gate/prose_lint.pyexempts a sentence holding more than one semicolon that also carries a comma, which is the rule's own exception for a semicolon-separated list whose items contain commas. The old sentence held two semicolons and several commas, so it read as that list. It was a series of three "that" clauses, and the first one carried commas, so the exemption fit its shape. The skip had nothing to do with the word "that" or the bold-led list item. Copilot's downstream finding was a preference for sentences over a semicolon series, and that preference is the better reading here, which is why the text still changes.Verification
git grep -n 'costs nothing;'finds nothing.scripts/build_dist.py --checkreports the generated distributions current.scripts/prose_lint.py --diff origin/developpasses on the changed files.local-strict-reviewpasses ran. The first found that the recast deploy sentence ran to 35 words, and the second commit splits it. The second pass found nothing this change introduced.Pre-existing findings, not filed
WORKFLOW.md:130,pre-existing: the bullet's opening sentence ("the leaf builds the tree, ships it to the host, and contributes norelease-asset-*") runs to 27 words under--check sentence-length. This change did not touch that text.WORKFLOW.md:130,pre-existing: the Retention (D5.6) sentence runs to 39 words under--check sentence-length. This change did not touch that text.🤖 Generated with Claude Code